Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112255
MIME-Version: 1.0
References: <AFBF0B96-BE69-4D51-A549-741D0597DAAF@cpanel.net> <CA+kxMuR6wwxX_V0UfjkVLbKeckP96iuw8qMiwTroMKSoGWjOGQ@mail.gmail.com>
In-Reply-To: <CA+kxMuR6wwxX_V0UfjkVLbKeckP96iuw8qMiwTroMKSoGWjOGQ@mail.gmail.com>
Date: Wed, 18 Nov 2020 23:04:49 +0100
Message-ID: <CAF+90c_9hczW6CeGAhPzwm+Bvyp0VCQUvRrgNjhPv5=jNYxzpw@mail.gmail.com>
To: Dan Ackroyd <Danack@basereality.com>
Cc: Dan Muey <dan@cpanel.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c77b3805b468cd33"
Subject: Re: [PHP-DEV] Was removing major version from apache module a mistake?
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000c77b3805b468cd33
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, Nov 18, 2020 at 10:54 PM Dan Ackroyd <Danack@basereality.com> wrote=
:

> On Tue, 10 Nov 2020 at 20:22, Dan Muey <dan@cpanel.net> wrote:
> >
> > Hello,
> >
> > Was removing the major version from apache module done on purpose
>
> It was done on purpose on 28 Jan 2019
> https://github.com/php/php-src/pull/3769
>
> Although it is annoying to have minor things like this change,
> projects need to be able to correct small mistakes instead of leaving
> them until the end of time.
>
> From elsewhere:
> > Conclusion Let=E2=80=99s =E2=80=9CDrop DSO in 8=E2=80=9D for now, and i=
f there is a large push
> to reinstate it, then
> > revisit our options starting with the simpler =E2=80=9CPatch PHP 8 to u=
ndo
> upstream=E2=80=99s change=E2=80=9D.
>
> Sounds good to me.
>
> cheers
> Dan
> Ack
>

FWIW, as the person who implemented the change, there was no very strong
reason to do it, it was just routine cleanup to drop major version numbers
in all places where they are not needed for technical reasons. (We used to
have hundreds of files that needed to be changed when the major version
number changed.)

If I had known at the time, or really at any point in the following one and
a half years, that this causes issues for cpanel, I would have simply
reverted the change, because it would be more trouble than it is worth.
However, as the issue only came up pretty late, many other projects will
have accounted for the new name by now and would be broken if we changed it
back.

Regards,
Nikita

--000000000000c77b3805b468cd33--