Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112200
MIME-Version: 1.0
References: <ae6b586d-68ed-cda0-2b4d-e60472a1b04c@gmx.de>
In-Reply-To: <ae6b586d-68ed-cda0-2b4d-e60472a1b04c@gmx.de>
Date: Sat, 7 Nov 2020 14:51:10 -0600
Message-ID: <CAESVnVohLQtpk2=9Yon=jg2+LuPLp9THSDvT92EiLeV9uG8ThA@mail.gmail.com>
To: "Christoph M. Becker" <cmbecker69@gmx.de>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000d171da05b38a7d48"
Subject: Re: [PHP-DEV] php-src Git hash abbreviation collisions
From: pollita@php.net (Sara Golemon)

--000000000000d171da05b38a7d48
Content-Type: text/plain; charset="UTF-8"

On Sat, Nov 7, 2020 at 5:14 AM Christoph M. Becker <cmbecker69@gmx.de>
wrote:

> I've just noticed a pull request[1] which suggests to no longer
> abbreviate the php-src Git hashes to 7 digits only, because there are
> already collisions.  Using 10 digits as suggested seems reasonable to
> me, but I wanted to check if there are other places affected than the RM
> tools.
>
> So, is anybody aware of some of our tooling also using 7 digit hash
> abbreviations?  Do we need to announce that change elsewhere than
> besides on <https://windows.php.net/>?
>
> [1] <https://github.com/php/web-rmtools/pull/15>
>
> Christoph
>
>
None of my personal tooling does any hash trimming at all, so no problems
here.
That PR seems 100% reasonable AFAICT.

-Sara

--000000000000d171da05b38a7d48--