Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112198
MIME-Version: 1.0
References: <CAF+90c8NkeuXXG-APLcrtikKcSwPhs6BDT7gzVM9xkAW8Ntwtw@mail.gmail.com>
In-Reply-To: <CAF+90c8NkeuXXG-APLcrtikKcSwPhs6BDT7gzVM9xkAW8Ntwtw@mail.gmail.com>
Date: Sat, 7 Nov 2020 14:30:27 -0600
Message-ID: <CAESVnVoc4McAKvJ-+V=wiy5aVDB-dNrDLCV5WeMtvVp0O80cgQ@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000bb8e0e05b38a3331"
Subject: Re: [PHP-DEV] Rename PhpToken::getAll()?
From: pollita@php.net (Sara Golemon)

--000000000000bb8e0e05b38a3331
Content-Type: text/plain; charset="UTF-8"

On Sat, Nov 7, 2020 at 3:09 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

> The PhpToken::getAll() API introduced in PHP 8.0 is of course inspired by
> the existing token_get_all() function. But arguably, the name is not that
> great.
>
> The reporter suggests to rename it into PhpToken::tokenize() instead, which
> seems like a sensible suggestion to me.
>
> Any thoughts on doing that rename? It's pretty late in the release cycle,
> but if we want to rename something, this is our last chance :)
>
>
Do I love a rename 3 weeks from GA? No.
Is there any good reason to object? Not really.  The change is super minor
and the functionality is new and as-yet undocumented.

Go for it.  The reasoning in favor is sound.

-Sara

--000000000000bb8e0e05b38a3331--