Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:112193 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 22907 invoked from network); 7 Nov 2020 15:08:48 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 7 Nov 2020 15:08:48 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 8ECD718050A for ; Sat, 7 Nov 2020 06:30:14 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM,HTML_MESSAGE,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-il1-f170.google.com (mail-il1-f170.google.com [209.85.166.170]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sat, 7 Nov 2020 06:30:14 -0800 (PST) Received: by mail-il1-f170.google.com with SMTP id g7so4047111ilr.12 for ; Sat, 07 Nov 2020 06:30:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nOdG4+XXDOck3GV2BNb7JSU0ZWF8lLF6wARq7SfgAvc=; b=cJCMA6jE4lh3bb1lglEfw/bIwYWj6Tdy3HmBlgnuzvo1ji6ncOAqv8l9tJdFktyOvK Z8WoN3PPwvJb0b9Jg8Xd7ImBmWjH7uDUtPA1JXdDu8H6It9p5X964MH/6UIp8zp9UEnk XS3vBI5KVLEDrf5jELRpRBmSZdEURVa9/rHgwCgRFyhrcyQqpSarzPNsszAhtKqyJWwp 2zddzY68DK6G/aBgiEan0awTduNGb+oV9TeFJSPRY5/DsgxBtmqCWF5K1uIxFHg0qllF XtWHVz+cpxznE14l1UZdJCVbCdhBnwTiWNLHtzWMv4aNWpvpiXTRueRD4reHInxzSEbt Oaqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nOdG4+XXDOck3GV2BNb7JSU0ZWF8lLF6wARq7SfgAvc=; b=SBSgrTGr7iC+7VXVAgEq86Fo3bVr5UQr7PRp9bQTmpC+TivQXApqhBVjsJq/h3Uk6H 19MLqjppkA8fzRLZ0NVYzkNFbqKY0lCDFoKmXB8NpIWMxEB1gbuOT5tGPVNCtV1Nyo7q XGhtVtqZRTRnCEh123EII3NVA+8RtDd/awbUHiDjgxvMAP8p1G0uWSLCaNkkTwqB5H1A xWXPGl5h1ytw9TdaeJzCUXfuaTdbSlcPCga69GouL44RMe3ER7cz9k+9yQdsg08qBqHG iO3pO45x0EVpusyDDw3onfLeQJ3CHpYF7wmdpP6Gjpx1uw2sWJOqOwYx7iRpp3Z4UxGp SYJw== X-Gm-Message-State: AOAM530MGcDUkO4M5I/YemVKw7EP45U6TrQ2Q2BxPoH++xkkzgHIcbmJ /rTuJF2Ngw3heq4uqWnPUK9sw963aHzpJR5AabY= X-Google-Smtp-Source: ABdhPJzlZS+QglS0O8LNNerspSABK8JvPGYDMK4g477Anqu06ipYLPuyQ9Hh6dzzNxlTKzJzqAeBjAGOSobvv1Qf8RU= X-Received: by 2002:a92:dd91:: with SMTP id g17mr4813934iln.180.1604759413435; Sat, 07 Nov 2020 06:30:13 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: Date: Sat, 7 Nov 2020 15:30:02 +0100 Message-ID: To: Nikita Popov Cc: PHP internals Content-Type: multipart/alternative; boundary="000000000000c9b3c205b3852a47" Subject: Re: [PHP-DEV] Rename PhpToken::getAll()? From: carusogabriel34@gmail.com (Gabriel Caruso) --000000000000c9b3c205b3852a47 Content-Type: text/plain; charset="UTF-8" On Sat, Nov 7, 2020, 10:10 Nikita Popov wrote: > Hi internals, > > Cross-posting from https://bugs.php.net/bug.php?id=80328 to a place where > someone might see it... > > The PhpToken::getAll() API introduced in PHP 8.0 is of course inspired by > the existing token_get_all() function. But arguably, the name is not that > great. > > The reporter suggests to rename it into PhpToken::tokenize() instead, which > seems like a sensible suggestion to me. > > Any thoughts on doing that rename? It's pretty late in the release cycle, > but if we want to rename something, this is our last chance :) > > Regards, > Nikita > > PS: Because I know someone is going to suggest it: No, we will not > introduce a separate PhpLexer class at this point in time. > Agreed, and as one of PHP 8.0 RM, I see no problem on doing this renaming, just make sure to document it. Naming stuff is hard, but it's never too late to improve it :) > --000000000000c9b3c205b3852a47--