Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112193
MIME-Version: 1.0
References: <CAF+90c8NkeuXXG-APLcrtikKcSwPhs6BDT7gzVM9xkAW8Ntwtw@mail.gmail.com>
In-Reply-To: <CAF+90c8NkeuXXG-APLcrtikKcSwPhs6BDT7gzVM9xkAW8Ntwtw@mail.gmail.com>
Date: Sat, 7 Nov 2020 15:30:02 +0100
Message-ID: <CAP=4hCJ43MgHMxr7BCuSgnR0RcEL_6wFztryzL6OrzO-Q0Ke8g@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000c9b3c205b3852a47"
Subject: Re: [PHP-DEV] Rename PhpToken::getAll()?
From: carusogabriel34@gmail.com (Gabriel Caruso)

--000000000000c9b3c205b3852a47
Content-Type: text/plain; charset="UTF-8"

On Sat, Nov 7, 2020, 10:10 Nikita Popov <nikita.ppv@gmail.com> wrote:

> Hi internals,
>
> Cross-posting from https://bugs.php.net/bug.php?id=80328 to a place where
> someone might see it...
>
> The PhpToken::getAll() API introduced in PHP 8.0 is of course inspired by
> the existing token_get_all() function. But arguably, the name is not that
> great.
>
> The reporter suggests to rename it into PhpToken::tokenize() instead, which
> seems like a sensible suggestion to me.
>
> Any thoughts on doing that rename? It's pretty late in the release cycle,
> but if we want to rename something, this is our last chance :)
>
> Regards,
> Nikita
>
> PS: Because I know someone is going to suggest it: No, we will not
> introduce a separate PhpLexer class at this point in time.
>

Agreed, and as one of PHP 8.0 RM, I see no problem on doing this renaming,
just make sure to document it.

Naming stuff is hard, but it's never too late to improve it :)

>

--000000000000c9b3c205b3852a47--