Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:112189 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 98032 invoked from network); 7 Nov 2020 09:48:28 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 7 Nov 2020 09:48:28 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id A878F1804D8 for ; Sat, 7 Nov 2020 01:09:51 -0800 (PST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-0.2 required=5.0 tests=BAYES_40,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE, RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mail-lj1-f172.google.com (mail-lj1-f172.google.com [209.85.208.172]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Sat, 7 Nov 2020 01:09:51 -0800 (PST) Received: by mail-lj1-f172.google.com with SMTP id y16so4143764ljk.1 for ; Sat, 07 Nov 2020 01:09:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=QU9JcfGKJzRuSmqcXmi8WJ09hOBGWF5XGP6nR4QvpH4=; b=TVsnWnX4gZZsAATiFhEZgZyV98bawuGTfigH4xQEj3gnuC7G2XJ+o63Hha15gtiUeT e9Kz75t5AkebFC/1kKoniS9Wk4+PTjKMhSAQHPt2iHAf4e28hdUmfv1GwGcn5MPua7v/ GYspw87rS0RZXc/5zb8zQMMGmET1OF3nvf6MkciHqjTwhD41dBzHC6bF6p0kdsZByNTI hKhToMbau7msqxmw6WyyqXa/GkhRev1xA9oNpc1WxzNdbBj68LXLgC73630H0B7+tlkJ TQqo6BH6S4gHq1O0pl37rviwjAbNZsFk1uhzuNoZ+4m8MFysE+O02oryU+uzBCGIWmqz mrnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=QU9JcfGKJzRuSmqcXmi8WJ09hOBGWF5XGP6nR4QvpH4=; b=sPX4N4lbGboHyNwnwn842ztmvE8/u8l8tcpz1xrV15bxUKWqZfamqmMOq2ygIAU7nL SG8MmerMTsrk+BMp+OqKYmvl3hEs9mTF6PzwUHD2pZQEmmzoumwO87q49sRpboFXGcus vPp+t5lo36FZl88No1x0GzSI2PCc5kjusWqLA6idPXOiJGR0oR+Wq15XEPlS7rNMPdoM Akl+F3ASd17smHW83j3gt3LNYhScXzIX1yYiyODYVKELxJyvyaGbSYrssyxQTo2u5wyW KF+Iw22D9iQGPdnOtAb/vIES54dehQMRIW4GhfjkNtvW1kU4dQ1f09ewclXCieICEU3q UtOw== X-Gm-Message-State: AOAM533j/IapEiuicmorV4DZGaIYtb6iQaR8yZqoQV5Ds4UImdPtbaTD yQIBbf8r+irCLS/GuQzp4V66jcJnbZq97RBxXs/2/afRiCZJ9Q== X-Google-Smtp-Source: ABdhPJyk9ifV/neDAW6Vq00Z0156LHsqox9kga9XI7iIXbD4U/wj89JZL6fX2DoQFmgbwPrmKoCDFX9dJd+4hR54XPM= X-Received: by 2002:a05:651c:95:: with SMTP id 21mr2109723ljq.307.1604740188442; Sat, 07 Nov 2020 01:09:48 -0800 (PST) MIME-Version: 1.0 Date: Sat, 7 Nov 2020 10:09:32 +0100 Message-ID: To: PHP internals Content-Type: multipart/alternative; boundary="000000000000e39b2905b380b093" Subject: Rename PhpToken::getAll()? From: nikita.ppv@gmail.com (Nikita Popov) --000000000000e39b2905b380b093 Content-Type: text/plain; charset="UTF-8" Hi internals, Cross-posting from https://bugs.php.net/bug.php?id=80328 to a place where someone might see it... The PhpToken::getAll() API introduced in PHP 8.0 is of course inspired by the existing token_get_all() function. But arguably, the name is not that great. The reporter suggests to rename it into PhpToken::tokenize() instead, which seems like a sensible suggestion to me. Any thoughts on doing that rename? It's pretty late in the release cycle, but if we want to rename something, this is our last chance :) Regards, Nikita PS: Because I know someone is going to suggest it: No, we will not introduce a separate PhpLexer class at this point in time. --000000000000e39b2905b380b093--