Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112091
MIME-Version: 1.0
References: <CAJmy8YGSWkzEu1g2c9o=+5jSHEXGb=vW0dKcEwrHtKGPyC+eCA@mail.gmail.com>
 <ffa2774b-757e-879d-7bfa-dc554e4cc04a@gmx.de> <CAESVnVpxUsXQnhMWMLovJWwW+HByx=R_OndcitQPUpg0c-axPw@mail.gmail.com>
 <4267ea59-e9fa-1231-7f4b-46d1204eb291@gmx.de> <CAESVnVoJR7wvJ8ZBDdWV8eW+o00xHPOfsf5txmBsyiED-7ev=Q@mail.gmail.com>
 <CAESVnVrYG-WWvU+PGSzUixznSL9sEzzeZ4E18Xn8OCAzHAY15g@mail.gmail.com>
In-Reply-To: <CAESVnVrYG-WWvU+PGSzUixznSL9sEzzeZ4E18Xn8OCAzHAY15g@mail.gmail.com>
Date: Wed, 21 Oct 2020 20:49:16 +0200
Message-ID: <CAJmy8YGuWN7DKna+_bi6Y7xWpf_nOuAVMApS1UdMqCXBDt1u_g@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [PHP-DEV] Re: want an Object-oriented interface for HashContext
From: divinity76@gmail.com (Hans Henrik Bergan)

@Rowan Tommins

>I think I'd prefer to drop the fluent interface (returning void on most
> things, and relevant values on others)

well both approaches has pros and cons,
 that said, the sample implementation Sara posted returns $this,
 if you (or anyone) feels strongly about it one way or the other, i
guess the php devs can vote on it


@Sara Golemon
thanks!
 (and you're the original pecl hash author, neat)

given the "PHP8 release manager" thing, i guess you have a lot of
other PHP8 stuff to focus on right now

> Happy to co-author an RFC with you if you'd like to get involved directly, or I can just pick up the ball and run with it if you'd rather make the feature request then step back.

stepping back sounds good to me, i have no idea how to do any of that stuff ^^

> No reply from Hans, so I've thrown together an implementation and will attach an RFC to it in the coming days.
> https://github.com/php/php-src/pull/6347

looks great to me, and you even took care of the hash_update_stream
return value issue ^^

On Sat, 17 Oct 2020 at 04:52, Sara Golemon <pollita@php.net> wrote:
>
> On Tue, Oct 13, 2020 at 12:04 PM Sara Golemon <pollita@php.net> wrote:
>>
>> On Tue, Oct 13, 2020 at 11:42 AM Christoph M. Becker <cmbecker69@gmx.de> wrote:
>>>
>>>
>>> > Happy to co-author an RFC with you if you'd like to get involved directly,
>>> > or I can just pick up the ball and run with it if you'd rather make the
>>> > feature request then step back.
>>>
>>> Please go with this, if you like.  Note that I didn't make the feature
>>> request; I just support it. :)
>>>
>>
>> Sorry for confusion. That part of my reply was aimed at Hans, but I didn't have his original message in my thread to reply to. :p
>>
>
> No reply from Hans, so I've thrown together an implementation and will attach an RFC to it in the coming days.
> https://github.com/php/php-src/pull/6347
>
> -Sara