Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112083
To: "internals@lists.php.net" <internals@lists.php.net>
Thread-Topic: Idea: Warning about named parameters with a missing constructor?
Thread-Index: AQHWpy9JfEcggMAw+ka3piJ2WMOckQ==
Date: Tue, 20 Oct 2020 23:00:43 +0000
Message-ID:
 <DM6PR07MB6618FA11638F81F3AC01EEC4F91F0@DM6PR07MB6618.namprd07.prod.outlook.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: cf364b8e-a752-41d4-cec8-08d8754bf954
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Oct 2020 23:00:43.8527
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM11HT214
Subject: Idea: Warning about named parameters with a missing constructor?
From: tysonandre775@hotmail.com (tyson andre)

Hi internals,=0A=
=0A=
Currently, if there is no constructor, php handles it just like `__construc=
t(...$args) {}`,=0A=
both for positional and named parameters. Is there any interest in changing=
 that to be a deprecation warning if one or more parameters are passed?=0A=
(or if 1 or more named parameters are passed)=0A=
=0A=
The default behavior of missing constructors would result in somewhat surpr=
ising behavior=0A=
for `new $className(paramName: 123)` if this was used unexpectedly=0A=
(silently ignoring it)=0A=
(Desired behavior would be to deprecate/warn/throw)=0A=
=0A=
```=0A=
php > class A {}=0A=
php > var_export(new A(paramName: 123));=0A=
A::__set_state(array(=0A=
))=0A=
php > var_export(new stdClass(paramName: 123));=0A=
(object) array(=0A=
)=0A=
php > var_export(new stdClass(123));=0A=
(object) array(=0A=
)=0A=
```=0A=
=0A=
(I don't think https://wiki.php.net/rfc/named_params mentioned this=0A=
(the current behavior follows from handling of extra positional parameters)=
,=0A=
and this mistake is probably unlikely in practice,=0A=
but if it were to occur it would very likely be a bug)=0A=
=0A=
PHP already throws ArgumentCountError for passing too many parameters for i=
nternal methods=0A=
so the default method not throwing is a surprise. I haven't yet looked into=
 how much code would break if this were changed.=0A=
=0A=
Aside: If a static analyzer such as Phan, Psalm, or PHPStan are set up, tho=
se bugs could be detected easily,=0A=
so the impact seems low, but I wonder if this type of bug could cause confu=
sion (or feel unexpected)=0A=
for those who are more familiar with other languages than they are with php=
.=0A=
=0A=
Thanks,=0A=
- Tyson=