Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:112035 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 14626 invoked from network); 12 Oct 2020 13:40:45 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 12 Oct 2020 13:40:45 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 3F045180511 for ; Mon, 12 Oct 2020 05:55:36 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from mout.gmx.net (mout.gmx.net [212.227.17.21]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Mon, 12 Oct 2020 05:55:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1602507333; bh=YzPWyYDAAiYVDy7UDEdMm4DYd4QINAUawddWfNf9EIo=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=TxfCOaYhvUIh9Z/ekYk73kURXRmKMTpnE5iwHq9JBnQQY3nt4H46CfDPhK9eejcMS 6EDo6Qb2N9RnRXXPAbTvMab4qlDhaj4n+WmUY8/sGiXZU9NtBOrUCQjQ10rw3cQZXo qzXu/Tb+2hAY5i/lJ3dgDoHYAkqmAkNquavkbFhM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.2.130] ([91.8.170.238]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MxDkm-1kH19o3yfI-00xYUX; Mon, 12 Oct 2020 14:55:33 +0200 To: Hans Henrik Bergan , internals@lists.php.net References: Message-ID: Date: Mon, 12 Oct 2020 14:55:32 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:MpmZD3gWqh+X3SJ3g90Wbs3uqv984wo9jkRM+oCDQAWfKSI4JMf WT/ZdLqvaqZ+c6/9++7JnSkJ2m2al+O+FBLU/KVGLsZs73DYoL56d7xFKRaW2GZQwE1RNa4 fzuptZvM0ngEvaYmP9GbKmAKldyCcsYnUbeyt2vtwWAKWK2dQcOuoh655cxB95sH9ySAzsy FvRx8JMvQp4AJ36pxjj4A== X-UI-Out-Filterresults: notjunk:1;V03:K0:UdnZVAztAvw=:u7/jcAR7OehNxUDq+1jiEE ZPMGpMZS7EibRmZpNmfc3XT4VkFrhPgXyCq+hXI4z112O/3C9s068qvNc1HpWoQH82B2/FM0v cjMZk7gj/hM0Vvy6xilDAzsMn50hPeqURgpnOi5EhBknTk8HbcsQO86YO4LnQmdiL5Fd9lYSy XHctBFzznjZ8ujYgvzSSiDKV4E3n4ez3Gl7Irzmxnp2iXPVboVjcup4uWzO9l6e/i7yavQ6Q3 U3HJtxaW2UM3xA7ee2mJohlZyPv0JRqQcDIwyMMin0fba07s6F+j4fybRn+pbkt6G+wr7q9bu Vzg6lBaP/zm4eZkFizdXAUCTPAEvx0Z+BCftrYW4jMXFv14JndfI2qZnHShD1eTC9FmjsITGt aVToYYeqRbs4r5+vnuuAvk/7Jylvyq3o0Nly20d+UZ4rjNVwBdSAgVzORNhapa5XsfmrIdiye tnPOwLy8L6O3rTiPlPi1R3hAGYjd5js4lcmSQ0IbIeCGsbqEqnGz3ylT07Tc7P7mWBnzelEXz Mh4nPON7Nreu+3q1xYXZoKhlAi9NobK3WfF1c2G+3+h4tgfXXVf4SLECVLom7rPwOsCi07w4U ZXKNach8dyTfAuzYGma52rRSKU9cT9KXE8qJdfy69CJrz0K/dyLi/w7o+fPgQz2c84DTIdgpz fCQW1KRcaIro8XI2S30AGretKo0irfO/UahyKdXY3BcouYM2JaIHUz9wD/gA/W2zFymAv8Q0l Mbuzj1Fg0PPd87WjKkCgi/Frn3SANswlZc0snclbDeUjnlwEyGI/5hDctO1v8FCs7ESJD49ng PSyLK/dvUZupAgBCxTKr1Cayev6GrtCmvJ9CPGYXpp6i9zj16nte/hEvW7L9FIg00MqSijXYh rNlNWCOTRFicVKKIqQHgoJokDxdDIqB+QMQ584FgkNGUvc/Y1OO8lGo1RE/tr+5tIsG6guHey jcpN0EeckIUh3ieAOR7zFImclVhoowZYfZ5YkW73H2Bhc52dRZvFNzkVocRGVwl3ERRWBSxZW 1n29IjTh5zXQKrESgkr/1nW65apuf/RCSjqtCXvMnxFL9o8z7/dsL7iA+fQEWz61C5In/jyxz moykCWDTTC474RAbk2n/AGN/4Vv4di6Gqbe9Je/GXo6IPPehiAbAKtiDPCYPeELvBvS1enPr1 Um+wFz10Iznh2bJC9oBXuDKwT+zNYzqXYLU8il5zAUC+doXQU/PGu/DdUE7t/KczgS83D6UEC b8O+AVLoZPIP50BcV0LI6rmB/Y9EjBkKytk1oSw== Subject: Re: want an Object-oriented interface for HashContext From: cmbecker69@gmx.de ("Christoph M. Becker") On 12.10.2020 at 13:49, Hans Henrik Bergan wrote: > something like > > $result =3D (new HashContext("SHA1"))->update($str1)->update($str2)->fin= al(); > > (userland sample imp: https://3v4l.org/lXd3u ) > > I tried asking on the bugtracker ( https://bugs.php.net/bug.php?id=3D802= 21 ) , > but was told to ask on this mailing list instead. Thanks for bringing this up on the mailing list! I basically very much support a proper OOP interface, but I think the method names should use camel-case (e.g. ::updateFile() instead of ::update_file()), and it might be appropriate to rename ::final() to ::finalize(). More bikeshedding regarding the method names, and maybe their signatures might be in order. We do not necessarily have to make these methods aliases of the existing functions, although that's of course possible. =2D- Christoph M. Becker