Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112021
MIME-Version: 1.0
References: <CAF+90c8w3Aw9gbdFYV+Qm7Gyo0187GUMS2PmuUzVkW78JQ_Q_w@mail.gmail.com>
 <CAESVnVqMwPmwswUyuyP32AP0oAeXGwF-ayCeh5HOKim+24M23A@mail.gmail.com>
 <33f82702-6126-fa36-48d6-71487cae1b72@gmx.net> <CALKiJKpG64Tvp1MhjUVZDn2gSo3T0pSmQGk831StD7vj+=3a8Q@mail.gmail.com>
In-Reply-To: <CALKiJKpG64Tvp1MhjUVZDn2gSo3T0pSmQGk831StD7vj+=3a8Q@mail.gmail.com>
Date: Wed, 7 Oct 2020 10:01:44 +0200
Message-ID: <CAF+90c-a=cywFH5sanz5Nd-ZgYJVyNo_ORdukY00gV9fBpM+hQ@mail.gmail.com>
To: Rowan Tommins <rowan.collins@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000059f97f05b11021c5"
Subject: Re: [PHP-DEV] Attributes and constructor property promotion
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000059f97f05b11021c5
Content-Type: text/plain; charset="UTF-8"

On Tue, Oct 6, 2020 at 6:59 PM Rowan Tommins <rowan.collins@gmail.com>
wrote:

> On Tue, 6 Oct 2020 at 17:20, Andreas Leathley <a.leathley@gmx.net> wrote:
>
> > From my understanding suppressing the validation errors in this
> > particular case would be a good solution, or are there any serious
> > downsides to that?
> >
>
>
> The downside presumably is that a library author could implement an
> attribute with a property-only restriction, and therefore write code
> handling parameter attributes with the assumption that that attribute won't
> be present. If a consumer of the library makes use of constructor property
> promotion, that assumption can be violated. I can't quite picture what that
> code would look like, though, since it's always necessary to filter the
> list of attributes to exclude those from other libraries.
>

Yeah, this is my own view as well. If an attribute appears in an unexpected
place, you'd just ignore it the same way you ignore all attributes you do
not "own". For manual implementations, you wouldn't even notice (because
for a property-only attribute, you'd only be looking at properties, duh)
and general attribute handling libraries can easily accommodate this case
(if it doesn't just happen automatically).

Regards,
Nikita

--00000000000059f97f05b11021c5--