Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112020
To: internals@lists.php.net
References: <CAF+90c8w3Aw9gbdFYV+Qm7Gyo0187GUMS2PmuUzVkW78JQ_Q_w@mail.gmail.com>
 <CAESVnVqMwPmwswUyuyP32AP0oAeXGwF-ayCeh5HOKim+24M23A@mail.gmail.com>
Message-ID: <d704214d-f1ac-70d0-d242-e5c4819e3fe9@fischer.name>
Date: Wed, 7 Oct 2020 09:22:06 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.3.1
MIME-Version: 1.0
In-Reply-To: <CAESVnVqMwPmwswUyuyP32AP0oAeXGwF-ayCeh5HOKim+24M23A@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Spam_score: -2.9
X-Spam_score_int: -28
X-Spam_bar: --
X-Spam_report: Spam detection software, running on the system "scanner01.home", has
 identified this incoming email as possible spam.  The original message
 has been attached to this so you can view it (if it isn't spam) or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Hi! On 06.10.20 17:15, Sara Golemon wrote: > My opinion on
    constructor property promotion (CPP) is that it's something > for small value
    object classes and should probably be regarded as > code-smell on larger
   classes. At the same time, annotations belong with > more complex objects
   and not so much with small "struct-like" classes. [...] 
 
 Content analysis details:   (-2.9 points, 5.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -1.0 ALL_TRUSTED            Passed through trusted hosts only via SMTP
 -1.9 BAYES_00               BODY: Bayes spam probability is 0 to 1%
                             [score: 0.0000]
 -0.0 NICE_REPLY_A           Looks like a legit reply (A)
X-CMAE-Envelope: MS4wfEAd4rZpeWv1TgBJf6X9OJsDLvf6JqTKO1ada+kwcozr1bsa46AOfNoF9KlG4TNXLLDfAVWfibvNBBw+f2xNfyt5xut4P/sXMClROz1kuh1l/ECV9ZUu
 oux9tgcCvC7DeANwHWVNUev80tgcfhQMTAfopdK5OopZ17aYHN3eAU62
Subject: Re: [PHP-DEV] Attributes and constructor property promotion
From: markus@fischer.name (Markus Fischer)

Hi!

On 06.10.20 17:15, Sara Golemon wrote:
> My opinion on constructor property promotion (CPP) is that it's something
> for small value object classes and should probably be regarded as
> code-smell on larger classes. At the same time, annotations belong with
> more complex objects and not so much with small "struct-like" classes.

Just wanted to chime in on this:

I can foresee already the impact CPP will have on dependency injection: 
sometimes you just have complex business logic with lots of (auto-wired) 
dependencies and have to pull in n+1 classes into the constructor.

Currently 5+ deps create 3*(5+) codelines for not much value. My point 
is that I see much more value _outside_ of "value object classes" with 
auto-wiring, reducing boilerplate _a lot_.


That said: I err on the side of forbidding it, if we've no clear 
consensus how to do it!

thanks,
- Makrs