Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:112015
MIME-Version: 1.0
References: <CAF+90c8w3Aw9gbdFYV+Qm7Gyo0187GUMS2PmuUzVkW78JQ_Q_w@mail.gmail.com>
In-Reply-To: <CAF+90c8w3Aw9gbdFYV+Qm7Gyo0187GUMS2PmuUzVkW78JQ_Q_w@mail.gmail.com>
Date: Tue, 6 Oct 2020 16:54:15 +0200
Message-ID: <CAF+90c-5mT1cB00a9eVZz9wu6Ryc7Oe9-XfkgBUgq1zSn9HXMQ@mail.gmail.com>
To: PHP internals <internals@lists.php.net>, Benjamin Eberlei <kontakt@beberlei.de>
Content-Type: multipart/alternative; boundary="000000000000c5e24505b101c6d0"
Subject: Re: Attributes and constructor property promotion
From: nikita.ppv@gmail.com (Nikita Popov)

--000000000000c5e24505b101c6d0
Content-Type: text/plain; charset="UTF-8"

On Mon, Sep 28, 2020 at 12:36 PM Nikita Popov <nikita.ppv@gmail.com> wrote:

> Hi internals,
>
> When the constructor property promotion landed, the question of how it
> interacts with attributes on promoted properties did not get fully
> resolved. See https://wiki.php.net/rfc/constructor_promotion#attributes
> for what the issue is.
>
> The behavior that landed was to apply the attribute is applied to both the
> parameter and the property. However, this was with the understanding that
> we may have to adjust the behavior later, in particular depending on how
> the whole "attribute target validation" turns out. The way it is now, using
> a property-only attribute on a promoted parameter may result in spurious
> validation errors.
>
> I wanted to bring up this topic now to make sure it's not forgotten... I
> still don't really know what the best behavior here is.
>
> Regards,
> Nikita
>

I want to bump this topic, we should resolve this one way or another soon.
My two proposals are:

https://github.com/php/php-src/pull/6244: Suppress target validation errors
for promoted properties (for property/parameter targets, the rest gets
validated as usual).

https://github.com/php/php-src/pull/6285: Forbid use of attributes on
promoted properties altogether, punting on making a decision here.

Regards,
Nikita

--000000000000c5e24505b101c6d0--