Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111948
MIME-Version: 1.0
References: <CAF+90c8w3Aw9gbdFYV+Qm7Gyo0187GUMS2PmuUzVkW78JQ_Q_w@mail.gmail.com>
 <CAEPJdunXkRw7UVrg=sm=dSSJ_Fd5VnBsd0oW9MGfK4NNGDyBTQ@mail.gmail.com>
 <CAG9XoMTtLcQ6jS_fCqNsL41q48zDvvfMZZjbwvRvOT5MJmCzAQ@mail.gmail.com>
 <CAEPJdunAjvfZgV52XHoaQJDzXz12K4m0suoqGdFitCT7QR7XAA@mail.gmail.com> <CAOWwgpn457VLk1gOgqXUXZ8OP=pMqF7YW4FG-oM5yZ=RvFpu5A@mail.gmail.com>
In-Reply-To: <CAOWwgpn457VLk1gOgqXUXZ8OP=pMqF7YW4FG-oM5yZ=RvFpu5A@mail.gmail.com>
Date: Mon, 28 Sep 2020 16:34:55 +0200
Message-ID: <CAG9XoMT+psKRLSUo070dNouQkeWBEXSLU=5c38L6Cnii4rNsnQ@mail.gmail.com>
To: Nicolas Grekas <nicolas.grekas+php@gmail.com>
Cc: Benjamin Eberlei <kontakt@beberlei.de>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009944be05b060921c"
Subject: Re: [PHP-DEV] Re: Attributes and constructor property promotion
From: benjamin.morel@gmail.com (Benjamin Morel)

--0000000000009944be05b060921c
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 28 Sep 2020 at 15:17, Nicolas Grekas <nicolas.grekas+php@gmail.com>
wrote:

> I assume the 80% case is properties, because attributes did not have
>> docblock annotations yet, that means this use-case isn't even possible a=
t
>> the moment. Yet annotations on properties are widespread (Doctrine ORM,
>> symfony validator, ...).
>>
>
> I'm 100% with Benjamin here, this is what will be the most useful to me
> also.
>

To be clear, I don't have a strong opinion against yours, I'm just pointing
out the fact that even though it might be useful, it might also be
confusing and create yet another WTF moment in PHP for developers. Sure, it
might make more sense to apply to the property. Sure, so far annotations
weren't possible on parameters. But is that obvious to the average
developer writing the attribute? A few years down the road, DI containers
may have broad support for annotating parameters for injection. Will it
still be obvious then that an attribute on a promoted property applies to
the property only?

I do agree that applying the attribute to both the property and the
parameter will probably never be useful, though. So, throwing an exception
and forcing the de-sugaring feels like the most sensible thing to do for me
in this case!

=E2=80=94 Benjamin

--0000000000009944be05b060921c--