Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111947
MIME-Version: 1.0
References: <CAF+90c8w3Aw9gbdFYV+Qm7Gyo0187GUMS2PmuUzVkW78JQ_Q_w@mail.gmail.com>
 <CAEPJdunXkRw7UVrg=sm=dSSJ_Fd5VnBsd0oW9MGfK4NNGDyBTQ@mail.gmail.com>
 <CAG9XoMTtLcQ6jS_fCqNsL41q48zDvvfMZZjbwvRvOT5MJmCzAQ@mail.gmail.com> <CAEPJdunAjvfZgV52XHoaQJDzXz12K4m0suoqGdFitCT7QR7XAA@mail.gmail.com>
In-Reply-To: <CAEPJdunAjvfZgV52XHoaQJDzXz12K4m0suoqGdFitCT7QR7XAA@mail.gmail.com>
Date: Mon, 28 Sep 2020 15:16:45 +0200
Message-ID: <CAOWwgpn457VLk1gOgqXUXZ8OP=pMqF7YW4FG-oM5yZ=RvFpu5A@mail.gmail.com>
To: Benjamin Eberlei <kontakt@beberlei.de>
Cc: Benjamin Morel <benjamin.morel@gmail.com>, Nikita Popov <nikita.ppv@gmail.com>, 
	PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000004688c805b05f7b7f"
Subject: Re: [PHP-DEV] Re: Attributes and constructor property promotion
From: nicolas.grekas+php@gmail.com (Nicolas Grekas)

--0000000000004688c805b05f7b7f
Content-Type: text/plain; charset="UTF-8"

>
> >> imho, we should pick the 80% use-case and advise to desugar the code if
> >> other behavior is desired. For me the 80% case is that the attribute
> only
> >> applies to the property, not to the parameter.
> >
> >
> > +1 for the desugaring advice in this case, however as a matter of
> > consistency I'd rather have it either apply to both the property and the
> > parameter, or just throw an exception if used on promoted properties,
> > whatever the 80% use-case is (source?)
> >
>
> We should assume that there are very few attributes that make sense to
> apply to *both* a property and an argument. I can't find any good example
> where this makes sense.
>
> Library developers shouldn't be forced to allow target argument only that
> it works in the ctor promotion case.
>
> I assume the 80% case is properties, because attributes did not have
> docblock annotations yet, that means this use-case isn't even possible at
> the moment. Yet annotations on properties are widespread (Doctrine ORM,
> symfony validator, ...).
>

I'm 100% with Benjamin here, this is what will be the most useful to me
also.

--0000000000004688c805b05f7b7f--