Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111934
MIME-Version: 1.0
References: <CAF+90c-p+g12EEEci-NrripG8M=SJ4o7AWZC+jdnL3_XkUKjEw@mail.gmail.com>
In-Reply-To: <CAF+90c-p+g12EEEci-NrripG8M=SJ4o7AWZC+jdnL3_XkUKjEw@mail.gmail.com>
Date: Fri, 25 Sep 2020 10:22:40 -0500
Message-ID: <CAESVnVpp5vZ_TJMe-zCNpzPvEWroOBvvzCR5sx3-EaayOoyXig@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000dadeed05b024e31b"
Subject: Re: [PHP-DEV] Attributes on property groups
From: pollita@php.net (Sara Golemon)

--000000000000dadeed05b024e31b
Content-Type: text/plain; charset="UTF-8"

On Tue, Sep 22, 2020 at 7:51 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

> Currently, placing an attribute on property (or constant) groups is not
> allowed:
>
> This is a case that was not explicitly mentioned in the RFC and we decided
> to be conversative when landing the initial implementation.
>
>
Conservative is a good default, but as Tyson pointed out, nobody is
confused about visibility modifiers applying to the entire group, I don't
believe they'd be confused about attribute application.
((Though I am curious what phpdoc syntax says here.))


> However, this restriction seems pretty arbitrary to me, and I think we
> should remove it. While there is some potential ambiguity as to whether the
> attribute applies to all properties or only the first one, I think the
> general expectation is that it should apply to all properties, just like
> the property type does.
>

Agreed. The limitation seems arbitrary and unnecessary.  Call this a
refinement of the feature previously landed, and let's get it into 8.0.

-Sara

--000000000000dadeed05b024e31b--