Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111933
MIME-Version: 1.0
References: <CAF+90c98HSy9-KYtCsycEJ8KZT-y3rTqq5+WO-ER0LQCobS=jA@mail.gmail.com>
In-Reply-To: <CAF+90c98HSy9-KYtCsycEJ8KZT-y3rTqq5+WO-ER0LQCobS=jA@mail.gmail.com>
Date: Fri, 25 Sep 2020 10:19:46 -0500
Message-ID: <CAESVnVo8E07WQ=1a3OrYtu4BfBQiLurgeWp=J+sKpW184Dv49w@mail.gmail.com>
To: Nikita Popov <nikita.ppv@gmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007115c105b024d99e"
Subject: Re: [PHP-DEV] Attributes and strict types
From: pollita@php.net (Sara Golemon)

--0000000000007115c105b024d99e
Content-Type: text/plain; charset="UTF-8"

On Tue, Sep 22, 2020 at 7:59 AM Nikita Popov <nikita.ppv@gmail.com> wrote:

> I would like to clarify how attributes are supposed to interact with
> strict_types. Consider the following code, split up into three files to
> make it clear that each one could have their own strict_types mode:
>
> MyAttribute.php
> <?php
> #[Attribute]
> class MyAttribute {
>     public function __construct(string $a) {}
> }
>
> UseOfMyAttribute.php
> <?php
> declare(strict_types=1);
> #[MyAttribute(42)]
> class Test {}
>
> AccessOfAttribute.php
> <?php
> var_dump((new
> ReflectionClass(Test::class'))->getAttributes()[0]->newInstance());
>
> Currently, what happens is that this code will construct the attribute,
> converting int 42 into string "42", even though UseOfMyAttribute.php has
> strict_types=1.
>
> My intuitive expectation here would be that we should be following the
> strict_types mode of wherever the attribute is being used (i.e.
> UseOfMyAttribute.php, not MyAttribute.php or AccessOfAttribute.php).
> Currently, we always assume strict_types=0.
>
> Is my expectation correct?
>
>
I would say that your expectation is correct, and I'm willing to call the
current behavior a bug.  No need to worry about FF here.

-Sara

--0000000000007115c105b024d99e--