Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111924
MIME-Version: 1.0
References: <CAF+90c98HSy9-KYtCsycEJ8KZT-y3rTqq5+WO-ER0LQCobS=jA@mail.gmail.com>
 <14b3e69c-f148-473e-a550-9624a22dfa3d@www.fastmail.com>
In-Reply-To: <14b3e69c-f148-473e-a550-9624a22dfa3d@www.fastmail.com>
Date: Tue, 22 Sep 2020 22:38:21 +0200
Message-ID: <CAG9XoMT=a8K9aeXTEG0Puby6j6wwmsbTt6nR+JaV_ik4iOieSQ@mail.gmail.com>
To: Larry Garfield <larry@garfieldtech.com>
Cc: php internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000056df7205afecf32f"
Subject: Re: [PHP-DEV] Attributes and strict types
From: benjamin.morel@gmail.com (Benjamin Morel)

--00000000000056df7205afecf32f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I'd expect it to obey the strict_types declaration of UseOfMyAttribute.php,
too. I see it as being where the attribute's constructor is "called", even
though the actual object instantiation happens somewhere else.

=E2=80=94 Benjamin

On Tue, 22 Sep 2020 at 16:11, Larry Garfield <larry@garfieldtech.com> wrote=
:

> On Tue, Sep 22, 2020, at 7:58 AM, Nikita Popov wrote:
> > Hi internals,
> >
> > I would like to clarify how attributes are supposed to interact with
> > strict_types. Consider the following code, split up into three files to
> > make it clear that each one could have their own strict_types mode:
> >
> > MyAttribute.php
> > <?php
> > #[Attribute]
> > class MyAttribute {
> >     public function __construct(string $a) {}
> > }
> >
> > UseOfMyAttribute.php
> > <?php
> > declare(strict_types=3D1);
> > #[MyAttribute(42)]
> > class Test {}
> >
> > AccessOfAttribute.php
> > <?php
> > var_dump((new
> > ReflectionClass(Test::class'))->getAttributes()[0]->newInstance());
> >
> > Currently, what happens is that this code will construct the attribute,
> > converting int 42 into string "42", even though UseOfMyAttribute.php ha=
s
> > strict_types=3D1.
> >
> > My intuitive expectation here would be that we should be following the
> > strict_types mode of wherever the attribute is being used (i.e.
> > UseOfMyAttribute.php, not MyAttribute.php or AccessOfAttribute.php).
> > Currently, we always assume strict_types=3D0.
> >
> > Is my expectation correct?
> >
> > Regards,
> > Nikita
>
> I could see an argument for either UseOfMyAttribute.php or
> AccessOfAttribute.php.  I think I would also favor UseOfMyAttribute.php,
> however, because if you get it wrong the place you have to change it is i=
n
> that file, so it should obey the setting in that file.
>
> --Larry Garfield
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--00000000000056df7205afecf32f--