Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111923
To: Nikita Popov <nikita.ppv@gmail.com>, PHP internals
	<internals@lists.php.net>
Thread-Topic: [PHP-DEV] Attributes on property groups
Thread-Index: AQHWkN8nY9VjCncRdEG432iDrDPWRql03mmv
Date: Tue, 22 Sep 2020 16:50:40 +0000
Message-ID:
 <DM6PR07MB6618BB02A471F9845B2D8ADCF93B0@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <CAF+90c-p+g12EEEci-NrripG8M=SJ4o7AWZC+jdnL3_XkUKjEw@mail.gmail.com>
In-Reply-To:
 <CAF+90c-p+g12EEEci-NrripG8M=SJ4o7AWZC+jdnL3_XkUKjEw@mail.gmail.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [QDwTls0bkleOHBCPyen1MYIEhrBdREJ/]
x-ms-publictraffictype: Email
x-incomingheadercount: 44
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: 92c5cb7b-d04e-4880-c63e-08d85f17a3d7
x-ms-traffictypediagnostic: BN7NAM10HT113:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 4mc3jRra18Kcd8lmnMvVNKOkz2hqdk8Cjq8QtaFBq6T/m/g3lI898G32xHH04e76fosG4ZeRin2FhIKcpHPzM1iisVrnOHpRvlm7lAuM0A7VjBDZgEpEF1TLiYCF3aHsAXqMu5BHgeVwARvyaoeN+V00dSHja+RWEW6BmJ1leI61xT7ZrX+oVnXIK49bQbVGfgfMPfnZ+yh8neYaovEf20prw/DCdiMQlPLTmfvHzQyOpHpwfKpUDNPdXv6SXm7V
x-ms-exchange-antispam-messagedata:
 cZaaZClWfYYP/BGJB2g+dau30nC73DOfu6g78/FcRKmqd155hMd8v9MijsRExlmwdSk30+JmuTSnEvEcGGUiLj1Vw2OOOXGJbi5KaRzapOa1i4aBeZwxBOM7kIg814xxPhRcZdAvjNvNmXkD1jQ9Hg==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: BN7NAM10FT050.eop-nam10.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 92c5cb7b-d04e-4880-c63e-08d85f17a3d7
X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2020 16:50:40.9579
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN7NAM10HT113
Subject: Re: [PHP-DEV] Attributes on property groups
From: tysonandre775@hotmail.com (tyson andre)

Hi Nikita,=0A=
=0A=
> Hi internals,=0A=
> =0A=
> Currently, placing an attribute on property (or constant) groups is not=
=0A=
> allowed:=0A=
> =0A=
> class Foo {=0A=
> =A0=A0=A0 #[NonNegative]=0A=
> =A0=A0=A0 public int $x, $y, $z;=0A=
> }=0A=
> // Fatal error: Cannot apply attributes to a group of properties=0A=
> =0A=
> This is a case that was not explicitly mentioned in the RFC and we decide=
d=0A=
> to be conversative when landing the initial implementation.=0A=
> =0A=
> However, this restriction seems pretty arbitrary to me, and I think we=0A=
> should remove it. While there is some potential ambiguity as to whether t=
he=0A=
> attribute applies to all properties or only the first one, I think the=0A=
> general expectation is that it should apply to all properties, just like=
=0A=
> the property type does.=0A=
> =0A=
> PR to allow this: https://github.com/php/php-src/pull/6186=0A=
> =0A=
> Any thoughts on this?=0A=
=0A=
That seems like a good idea and doesn't seem like an ABI change. I'm surpri=
sed this was a special case in the original implementation.=0A=
I wouldn't consider it a BC break if code that was previously a CompileErro=
r no longer threw a CompileError.=0A=
=0A=
The attribute node occurs before property modifiers such as `private static=
`, which already pretty clearly apply=0A=
to all elements in an attribute group, not just the first element.=0A=
=0A=
Regards,=0A=
- Tyson=