Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111918
MIME-Version: 1.0
References: <CAF+90c-p+g12EEEci-NrripG8M=SJ4o7AWZC+jdnL3_XkUKjEw@mail.gmail.com>
 <CADyq6sLttgmfzmU6zYU2xHi5DBPCbEnutRZHkhiU1+N4nFRNmQ@mail.gmail.com>
In-Reply-To: <CADyq6sLttgmfzmU6zYU2xHi5DBPCbEnutRZHkhiU1+N4nFRNmQ@mail.gmail.com>
Date: Tue, 22 Sep 2020 16:23:14 +0300
Message-ID: <CANeKSiQjSR0Ru02i-3SBNgR1o-9wnmBdWq2b5=3Ps5fuVC_oFg@mail.gmail.com>
To: Marco Pivetta <ocramius@gmail.com>
Cc: Nikita Popov <nikita.ppv@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000003d8dfc05afe6df15"
Subject: Re: [PHP-DEV] Attributes on property groups
From: benas.molis.iml@gmail.com (Benas IML)

--0000000000003d8dfc05afe6df15
Content-Type: text/plain; charset="UTF-8"

And why would we want to do that?

On Tue, Sep 22, 2020, 4:04 PM Marco Pivetta <ocramius@gmail.com> wrote:

> Probably easier/simpler to deprecate (then remove) property declaration
> groups, no?
>
> On Tue, Sep 22, 2020, 14:51 Nikita Popov <nikita.ppv@gmail.com> wrote:
>
> > Hi internals,
> >
> > Currently, placing an attribute on property (or constant) groups is not
> > allowed:
> >
> > class Foo {
> >     #[NonNegative]
> >     public int $x, $y, $z;
> > }
> > // Fatal error: Cannot apply attributes to a group of properties
> >
> > This is a case that was not explicitly mentioned in the RFC and we
> decided
> > to be conversative when landing the initial implementation.
> >
> > However, this restriction seems pretty arbitrary to me, and I think we
> > should remove it. While there is some potential ambiguity as to whether
> the
> > attribute applies to all properties or only the first one, I think the
> > general expectation is that it should apply to all properties, just like
> > the property type does.
> >
> > PR to allow this: https://github.com/php/php-src/pull/6186
> >
> > Any thoughts on this?
> >
> > Regards,
> > Nikita
> >
>

--0000000000003d8dfc05afe6df15--