Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111914
MIME-Version: 1.0
Date: Tue, 22 Sep 2020 14:51:22 +0200
Message-ID: <CAF+90c-p+g12EEEci-NrripG8M=SJ4o7AWZC+jdnL3_XkUKjEw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000084a9b505afe66da0"
Subject: Attributes on property groups
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000084a9b505afe66da0
Content-Type: text/plain; charset="UTF-8"

Hi internals,

Currently, placing an attribute on property (or constant) groups is not
allowed:

class Foo {
    #[NonNegative]
    public int $x, $y, $z;
}
// Fatal error: Cannot apply attributes to a group of properties

This is a case that was not explicitly mentioned in the RFC and we decided
to be conversative when landing the initial implementation.

However, this restriction seems pretty arbitrary to me, and I think we
should remove it. While there is some potential ambiguity as to whether the
attribute applies to all properties or only the first one, I think the
general expectation is that it should apply to all properties, just like
the property type does.

PR to allow this: https://github.com/php/php-src/pull/6186

Any thoughts on this?

Regards,
Nikita

--00000000000084a9b505afe66da0--