Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111881
Date: Thu, 17 Sep 2020 15:25:07 +0200
To: PHP internals <internals@lists.php.net>
Message-ID: <20200917152507.1203e8e2@mcmic-probook.opensides.be>
In-Reply-To: <CAFPFaMKCoLuYfZfdXqG=tp5EkLoODuOjNPEB2HaLv_p54Ar=2Q@mail.gmail.com>
References: <20200917145304.4a6cfe45@mcmic-probook.opensides.be>
	<CAFPFaMKCoLuYfZfdXqG=tp5EkLoODuOjNPEB2HaLv_p54Ar=2Q@mail.gmail.com>
Organization: FusionDirectory
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [PHP-DEV] Stubs in ext/ldap
From: come.chilliet@fusiondirectory.org (=?UTF-8?B?Q8O0bWU=?= Chilliet)

Le Thu, 17 Sep 2020 15:03:05 +0200,
"G. P. B." <george.banyard@gmail.com> a =C3=A9crit :
> A lot of the documentation is not up to date and will needs to be updated
> after
> there has been a check of the argument names for consistency with other
> extensions in regards to named params, the stubs are the source of trust.=
 =20

I think a review of ext/ldap is needed then.

> UNKNOWN means that the default value cannot be specified due to some reas=
on
> mostly the case for arguments passed by references or funcky function
> signature
> implementation which check the number of argument passed to the function.
>  =20
> > I would like to fix those conflicts.
> > Basically my questions are:
> > 1) What is the difference between s and S in zend_parse_parameters and =
how
> > do
> >  they behave for a NULL value? =20
>=20
> None in regards to userland as 's' is a char* followed by a size_t ad 'S'
> is a zend_string.
> As for all internal functions which are not nullable they will coerce null
> to the respective type
> so for a string argument null would become an empty string. =20

So in the example of ldap_bind:
	if (zend_parse_parameters(ZEND_NUM_ARGS(), "r|ss", &link,
&ldap_bind_dn, &ldap_bind_dnlen, &ldap_bind_pw, &ldap_bind_pwlen) !=3D SUCC=
ESS)
{ RETURN_THROWS(); }

With ldap_bind($link, NULL), ldap_bind_dn is not NULL but an empty string?

> > 2) What would changing =3D UNKNOWN to =3D NULL impact?   =20
>=20
> Explicit support for nullable types in the C implementation
>  =20
> > 3) When a function like ldap_bind is called, is calling ldap_bind($link=
),
> > and
> >  ldap_bind($link, NULL) changing anything else than ZEND_NUM_ARGS? =20
>=20
> This relates to point 1 and 2 above, if there is no support for nullable
> types
> passing null can change the meaning of it. =20

Then I think most of these needs to be changed to NULL with explicit suppor=
t,
 as it was most likely what was intended. (the underlying C functions from
 libldap accepts NULL).
Also, there are tests like ldap_sasl_bind_basic.phpt which tests a NULL
 parameter.

What is the dead line for this kind of changes in ext/ldap regarding to PHP=
-8?

C=C3=B4me