Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111871
MIME-Version: 1.0
References: <0736f00e-1373-fa74-8409-6a6e1084f0dd@beccati.com>
In-Reply-To: <0736f00e-1373-fa74-8409-6a6e1084f0dd@beccati.com>
Date: Wed, 16 Sep 2020 12:46:40 +0200
Message-ID: <CAF+90c8dMfAwPUGruNTV-3zpEOLSnDUsGKzSzb_DyAmwqZh5mg@mail.gmail.com>
To: Matteo Beccati <php@beccati.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007d252e05af6bfcf1"
Subject: Re: [PHP-DEV] Git workflow, PRs and php-cvs ML
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000007d252e05af6bfcf1
Content-Type: text/plain; charset="UTF-8"

On Wed, Sep 16, 2020 at 12:44 PM Matteo Beccati <php@beccati.com> wrote:

> Hey everybody,
>
> I've noticed a test failing today on my CI and went through my local
> php-cvs ML archive to see what could have caused it, without finding a
> match. That has happened a few times already and I believe it was always
> with some "Closes GH-XXX" commits.
>
> I'm just guessing here, but maybe in those cases the git workflow from
> our wiki page wasn't properly followed when merging pull requests?
>
> https://wiki.php.net/vcs/gitworkflow
>
> Today's example:
> https://github.com/php/php-src/pull/5803
>

No, this just means that your CI is running tests that our CI doesn't. In
this case, you are probably using a different MySQL version and thus run a
different subset of tests.

Nikita

--0000000000007d252e05af6bfcf1--