Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:111870 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 80920 invoked from network); 16 Sep 2020 11:35:26 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 16 Sep 2020 11:35:26 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id DCB7918050A for ; Wed, 16 Sep 2020 03:43:48 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: * X-Spam-Status: No, score=1.6 required=5.0 tests=BAYES_50,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DOS_RCVD_IP_TWICE_B, SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from box.beccati.com (box.beccati.com [176.9.123.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Wed, 16 Sep 2020 03:43:48 -0700 (PDT) Received: from authenticated-user (box.beccati.com [176.9.123.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by box.beccati.com (Postfix) with ESMTPSA id 6ED4B2002D2 for ; Wed, 16 Sep 2020 12:43:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=beccati.com; s=mail; t=1600253026; bh=Rhk+I9bVQchZeOlSrUIRKmvjIjIxX47UCdv+4Vk6Ygo=; h=To:From:Subject:Date:From; b=lpYJI8UvlsBWy4iF4FAvi9Bcy/9VaNScvV4u2cCapHqsMSeLyxNo5c5vV70XTthcy yqqBSIp1JJZOL32WzCrGf76gyOi/yRPqLIUPfNlJol/vPCbznRUM0qo9GSvNblopsg PsIS8cJd7MOHYgRlNx7nxPLEfpUQNpUpxyy865oB+VhtZqyPNG34zacLkwEM022qsS GdkQ+Fg8A6Pq3WiQ7WBBOxiS3uZOZ2oetoUFznVk0GA+nIzPHyr6pzKCHCV75Q+BDn huUNCYkOieCG52osFKCc1q95skrPbu/5WKzrsrapbOykU2CMNsXjs9A/5n2C+QNYh6 Ko/M4/OvLRe2g== To: internals@lists.php.net Message-ID: <0736f00e-1373-fa74-8409-6a6e1084f0dd@beccati.com> Date: Wed, 16 Sep 2020 12:43:40 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Git workflow, PRs and php-cvs ML From: php@beccati.com (Matteo Beccati) Hey everybody, I've noticed a test failing today on my CI and went through my local php-cvs ML archive to see what could have caused it, without finding a match. That has happened a few times already and I believe it was always with some "Closes GH-XXX" commits. I'm just guessing here, but maybe in those cases the git workflow from our wiki page wasn't properly followed when merging pull requests? https://wiki.php.net/vcs/gitworkflow Today's example: https://github.com/php/php-src/pull/5803 Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/