Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111832
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=_201f03fa0440946742b9098a4517c3c8"
Date: Thu, 03 Sep 2020 18:36:46 +0200
To: Sara Golemon <pollita@php.net>
Cc: PHP internals <internals@lists.php.net>
In-Reply-To: <CAESVnVohQ6cCzriif1e7Px=roehFb4p_==EpXc8BTHK9Xat9KQ@mail.gmail.com>
References: <2868e0ed4e7ebc09b568471c913079516f93fd2fc95e97b0ffea192db1e04275@mahalux.com>
 <CAEsg9X1_RkAFOKr+PPSesJEdwnbB55LuAfE8_HgGw5_cC1irvQ@mail.gmail.com> <CAESVnVog3nWxapuCqN8c3fxFPPbpOyQHnj1UQbGFS5mpN7bx3g@mail.gmail.com>
 <CAEsg9X3N3UGPzFXddHZe7fJVPs0J5RyLysmyOdyA6PGrf+Oq-Q@mail.gmail.com> <CAESVnVohQ6cCzriif1e7Px=roehFb4p_==EpXc8BTHK9Xat9KQ@mail.gmail.com>
Message-ID: <338f74ebb60ebac19ec4316f2e64d720988c60df9ac9e116a5ab364974fea8fe@mahalux.com>
Subject: Re: [PHP-DEV] Pass source object to clone like __clone($origThis)
From: vorismi3@fel.cvut.cz (=?UTF-8?Q?Michael_Vo=C5=99=C3=AD=C5=A1ek_-_=C4=8CVUT_FEL?=)

--=_201f03fa0440946742b9098a4517c3c8
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8; format=flowed

The goal is to be able to access the original object and it's id/hash. 

Usecases: 

- something is associated with the object using the object id/hash and
it needs to be cloned as well 

we need the original object to obtain it's id/hash for spl_object_id and
spl_object_hash methods 

- bounded Closures ar associated with the original object and they needs
to be rebound to the cloned object 

example: 

public function __clone(self $origThis)
{
    if ((new \ReflectionFunction($this->fx))->getClosureThis() ===
$origThis) {
        $this->fx = \Closure::bind($this->fx, $this);
    }
} 

Modification of php is simple: 

https://github.com/php/php-src/pull/6063/files#diff-beea8c5a8ceb318220b34b73e4ecfc98R252


we simply pass the old object as 1 parameter. I belive, passing old
object have positives and no performance nor compatibility impact. All
other current solutions require an extra property and a lot of code, as
assigning in constructor is not enough (due serialization etc.), or it
is even impossible, if object was created using reflection without
constructor. 

With kind regards / Mit freundlichen Grüßen / S přátelským pozdravem,

Michael Voříšek

On 3 Sep 2020 18:00, Sara Golemon wrote:

> On Thu, Sep 3, 2020 at 10:40 AM David Rodrigues <david.proweb@gmail.com>
> wrote:
> 
>> Now I rethinked about what I said. Really, maybe clone is not the best
>> option. So maybe we can just use a method that will clone and will have
>> access to both informations. But I don't know if it solves the original
>> message.
>> 
>> public function getUserCopy() {
>> $userCopy = clone $this;
>> $this->copies[] = $userCopy;
>> 
>> return $userCopy;
>> }
> If your goal is to track copies, then a static makes much more sense.
> 
> class AllKnowing {
> private static $copies = [];
> 
> public function __construct(...) {
> self::$copies[] = $this;
> ....
> }
> 
> public function __clone() {
> self::$copies[] = $this;
> }
> }
> 
> -Sara
--=_201f03fa0440946742b9098a4517c3c8--