Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111758
MIME-Version: 1.0
References: <DM6PR07MB6618683DF0ABBA43C4FC7CB8F9510@DM6PR07MB6618.namprd07.prod.outlook.com>
In-Reply-To: <DM6PR07MB6618683DF0ABBA43C4FC7CB8F9510@DM6PR07MB6618.namprd07.prod.outlook.com>
Date: Mon, 31 Aug 2020 21:54:56 -0400
Message-ID: <CAKuGYLTYZL7cmnqh9-8ygmkcdJes0S6EpNV4MYbCQSW2Z_RhPQ@mail.gmail.com>
To: tyson andre <tysonandre775@hotmail.com>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ff65ef05ae36ceb4"
Subject: Re: [PHP-DEV] [RFC] Global functions any() and all() on iterables
From: matthewmatthew@gmail.com (Matthew Brown)

--000000000000ff65ef05ae36ceb4
Content-Type: text/plain; charset="UTF-8"

This would be a fantastic addition, and it would also alleviate an issue in
static analysis land where it's very tricky (in the general case) to verify
exactly what implications successfully completing a given foreach loop has
on the array being iterated over (e.g.
https://github.com/vimeo/psalm/issues/649).

Using this function would make user intent much clearer to static analysis
tools, and also (as RFC describes) increase code legibility.


On Mon, 31 Aug 2020 at 19:56, tyson andre <tysonandre775@hotmail.com> wrote:

> Hi internals,
>
> I've created an RFC for https://wiki.php.net/rfc/any_all_on_iterable
>
> This was proposed 2 days ago in https://externals.io/message/111711 with
> some interest
> ("Proposal: Adding functions any(iterable $input, ?callable $cb = null,
> int $use_flags=0) and all(...)")
>
> - The $use_flags parameter was removed
>
> The primitives any() and all() are a common part of many programming
> languages and help in avoiding verbosity or unnecessary abstractions.
>
> -
> https://hackage.haskell.org/package/base-4.14.0.0/docs/Prelude.html#v:any
> -
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/some
> - https://docs.python.org/3/library/functions.html#all
> -
> https://docs.oracle.com/javase/8/docs/api/java/util/stream/Stream.html#allMatch-java.util.function.Predicate-
>
> For example, the following code could be shortened significantly
>
> ```
> // Old version
> $satisifes_predicate = false;
> foreach ($item_list as $item) {
>     if (API::satisfiesCondition($item)) {
>         $satisfies_predicate = true;
>         break;
>     }
> }
> if (!$satisfies_predicate) {
>     throw new APIException("No matches found");
> }
>
> // New version is much shorter and readable
> if (!any($item_list, fn($item) => API::satisfiesCondition($item))) {
>     throw new APIException("No matches found");
> }
> ```
>
> That example doesn't have any suitable helpers already in the standard
> library.
> Using array_filter would unnecessarily call satisfiesCondition even after
> the first item was found,
> and array_search doesn't take a callback.
>
> A proposed implementation is https://github.com/php/php-src/pull/6053 -
> it takes similar flags and param orders to array_filter().
>
> Thanks,
> - Tyson
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--000000000000ff65ef05ae36ceb4--