Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111709
MIME-Version: 1.0
References: <BYAPR05MB547890C193C6DD695BA5D964DE5B0@BYAPR05MB5478.namprd05.prod.outlook.com>
 <5f4037e3.1c69fb81.e0b66.dcd6SMTPIN_ADDED_MISSING@mx.google.com>
 <CAPyj-LCMz7uDZkWWF73d3n+17oYFaP5UZAyYYC6noF2Bivz6=w@mail.gmail.com> <DM6PR07MB6618FB21EEFDCB8C26C7AA97F9530@DM6PR07MB6618.namprd07.prod.outlook.com>
In-Reply-To: <DM6PR07MB6618FB21EEFDCB8C26C7AA97F9530@DM6PR07MB6618.namprd07.prod.outlook.com>
Date: Sat, 29 Aug 2020 16:25:40 -0300
Message-ID: <CAEsg9X3M8f=ZiQgB-a5hcQ0xh9JDxNp9DmMtF3A3TDA=+SbAeA@mail.gmail.com>
To: tyson andre <tysonandre775@hotmail.com>
Cc: Ilija Tovilo <tovilo.ilija@gmail.com>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000002aa8c505ae09230f"
Subject: Re: [PHP-DEV] Re: Should hash comments be deprecated?
From: david.proweb@gmail.com (David Rodrigues)

--0000000000002aa8c505ae09230f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

I have suggested on past a declare() to help in cases like that:

declare(php_version =3D "8.0");

It could be declared to new PHP files, so old files could supports # as
comments and new files will not.

Other option is supports <?php8 syntax. And for future <?php81 for 8.1, so
on.

Em s=C3=A1b, 29 de ago de 2020 14:22, tyson andre <tysonandre775@hotmail.co=
m>
escreveu:

> Hi internals,
>
> If it turns out that the impact on legacy applications, legacy libraries,
> or holding back upgrades is a concern for others
> (I'm not sure what the most common opinion is),
> another option would be a system ini setting
>
> `hash_comment =3D 0|1|2`
> 0 - disable `#comment` support completely when parsing/lexing - throw a
> ParseError while lexing and return T_ERROR in token_get_all
> 1 - (default) emit a compilation warning or deprecation notice when
> parsing files mentioning that hash comments will be removed in a future
> major release. Do this only for the first comment.
> 2 - allow it silently (possibly an unnecessary option to provide)
>
> Then, this could be gradually strictened
>
> - Forbid option 2 in php 8.x
> - change the default ini setting value to 0 in 8.x or 9.0
> - Add a configuration setting in php 8.x or 9.x to always disable hash
> comments
> - Remove support
>
> > Correct me if I'm wrong, but the shebang goes before the PHP opening
> > tag <?php and thus this is not relevant. In fact, shebang is already a
> > special case.
>
> Yes, shebang can only be parsed on the first line of a script - before
> `<?php` sections.
>
> Thanks,
> - Tyson
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: https://www.php.net/unsub.php
>
>

--0000000000002aa8c505ae09230f--