Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111708
To: Ilija Tovilo <tovilo.ilija@gmail.com>, PHP internals
	<internals@lists.php.net>
Thread-Topic: [PHP-DEV] Re: Should hash comments be deprecated?
Thread-Index: AQHWd9/i7uMAZC0X8UefGA07rPcslqlDEEFugAxLBmk=
Date: Sat, 29 Aug 2020 17:22:26 +0000
Message-ID:
 <DM6PR07MB6618FB21EEFDCB8C26C7AA97F9530@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <BYAPR05MB547890C193C6DD695BA5D964DE5B0@BYAPR05MB5478.namprd05.prod.outlook.com>
 <5f4037e3.1c69fb81.e0b66.dcd6SMTPIN_ADDED_MISSING@mx.google.com>,<CAPyj-LCMz7uDZkWWF73d3n+17oYFaP5UZAyYYC6noF2Bivz6=w@mail.gmail.com>
In-Reply-To:
 <CAPyj-LCMz7uDZkWWF73d3n+17oYFaP5UZAyYYC6noF2Bivz6=w@mail.gmail.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [zr1Ej6TQYj6FhO0RHlZbcG/qn3BsCz0d3OnbKL1aW1rp3LhCRTwU5KmeE/PCGHXC]
x-ms-publictraffictype: Email
x-incomingheadercount: 44
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: f98e59ae-b8ac-45ca-359f-08d84c4019cd
x-ms-traffictypediagnostic: SN1NAM04HT082:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 3+ZstI9EwhmuhzhLXOWbWJ+XRh3lkJv6olGftGFu/4Ifed7ilKf0nfe2ytB3AFJPVmH96FOOW4NDXSK+eC1DJpqekInIRmH5+zT6B7WtIz+h8Jow5+046UAjdUbgUbI71wqTcquHHFBRNFqruqGoIoa7EXTZomTILt1J1PXYrIuYXHlWmbMGNCsuYQCNqDYLPFCP6E6CGiYr4Qh5ZZf6xA==
x-ms-exchange-antispam-messagedata:
 g5GCMgmtf1NpGHwWFEpvt2z8FPNoSAw2vzW/AjEtf5aeAPROGNOE7MfWST5rERhsGtiM97WSF+35Zr3UF5Vs3FonGqQwW9XeFJUZwCeGxe55n83T2Q71PMcHedBkjNIQ9tT7WZdkOXcsy4Sbhq2g1GawK8MLc8nbS+rgoa/S1+s7YyvPOntkSgfCmSktOSRI9HPPNI95G+GvtZgqQxnEgQ==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: SN1NAM04FT033.eop-NAM04.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: f98e59ae-b8ac-45ca-359f-08d84c4019cd
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Aug 2020 17:22:26.6602
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1NAM04HT082
Subject: Re: [PHP-DEV] Re: Should hash comments be deprecated?
From: tysonandre775@hotmail.com (tyson andre)

Hi internals,=0A=
=0A=
If it turns out that the impact on legacy applications, legacy libraries, o=
r holding back upgrades is a concern for others=0A=
(I'm not sure what the most common opinion is),=0A=
another option would be a system ini setting=0A=
=0A=
`hash_comment =3D 0|1|2`=0A=
0 - disable `#comment` support completely when parsing/lexing - throw a Par=
seError while lexing and return T_ERROR in token_get_all=0A=
1 - (default) emit a compilation warning or deprecation notice when parsing=
 files mentioning that hash comments will be removed in a future major rele=
ase. Do this only for the first comment.=0A=
2 - allow it silently (possibly an unnecessary option to provide)=0A=
=0A=
Then, this could be gradually strictened=0A=
=0A=
- Forbid option 2 in php 8.x=0A=
- change the default ini setting value to 0 in 8.x or 9.0=0A=
- Add a configuration setting in php 8.x or 9.x to always disable hash comm=
ents=0A=
- Remove support =0A=
=0A=
>=A0Correct me if I'm wrong, but the shebang goes before the PHP opening=0A=
> tag <?php and thus this is not relevant. In fact, shebang is already a=0A=
> special case.=0A=
=0A=
Yes, shebang can only be parsed on the first line of a script - before `<?p=
hp` sections.=0A=
=0A=
Thanks,=0A=
- Tyson=