Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111701
To: "G. P. B." <george.banyard@gmail.com>
Cc: =?UTF-8?Q?Dino_Pejakovi=c4=87?= <dino.pejakovic@voxdiversa.hr>,
 PHP internals <internals@lists.php.net>,
 Christoph Michael Becker <cmb@php.net>, Derick Rethans <derick@php.net>,
 Sara Golemon <pollita@php.net>, Gabriel Caruso <carusogabriel34@gmail.com>
References: <08b959f5-7652-5e8a-562a-c2659facec8c@voxdiversa.hr>
 <c2e43e61-bc14-2b0f-6fdd-28235153ced8@beccati.com>
 <CAFPFaMJTErRzCuA5RWAsfPmqUr9Hx22+4RuCH9NKKioVgf+3OA@mail.gmail.com>
 <20277058-b463-038a-4333-eacd023ccdc4@beccati.com>
Message-ID: <3220cfac-aeca-0e28-3574-77e2b2c89b1d@beccati.com>
Date: Fri, 28 Aug 2020 09:18:55 +0200
MIME-Version: 1.0
In-Reply-To: <20277058-b463-038a-4333-eacd023ccdc4@beccati.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] PDO fetch performance problems with many bind
 parameters
From: php@beccati.com (Matteo Beccati)

Hi George,

/cc release managers - pls don't hate me ;-)

On 27/08/2020 10:23, Matteo Beccati wrote:
>
> On 26/08/2020 19:28, G. P. B. wrote:
>> This can still target PHP 8.0 as this seems to be akin to a bug this
>> might even be applicable to PHP 7.3/7.4. Anyways, good catch.
>
> You could be right. I've created a draft PR for review: Dino could yo> please benchmark it and get back with results?> >
https://github.com/php/php-src/pull/6047
The PR seems to fix the issue:

https://bugs.php.net/bug.php?id=80027

Dino's bench script takes 3s on vanilla PHP8 and 120ms with the patch,
so it's seems a fairly good win. The fetching part alone goes down from
2.9s to 3ms.

The way it's been fixed should be backwards and forwards compatible with
no real need to bump PDO_VERSION_API: external PDO driver extensions
wanting to use the param_evt_skip flags could simply set them via a
preprocessor macro when compiled for PHP8+.

For now I've optimised the pdo_pgsql/mysql/sqlite extensions, but I will
look into the other bundled ones too.

Would you think it's sensible to treat this as a bug fix and target
7.3+? Or is it better to do PHP8 only? Or?


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/