Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111697
To: "G. P. B." <george.banyard@gmail.com>, Matteo Beccati <php@beccati.com>
Cc: PHP internals <internals@lists.php.net>
References: <08b959f5-7652-5e8a-562a-c2659facec8c@voxdiversa.hr>
 <c2e43e61-bc14-2b0f-6fdd-28235153ced8@beccati.com>
 <CAFPFaMJTErRzCuA5RWAsfPmqUr9Hx22+4RuCH9NKKioVgf+3OA@mail.gmail.com>
Message-ID: <b81189a0-e7eb-5714-e92d-0f9ed5d989a0@voxdiversa.hr>
Date: Wed, 26 Aug 2020 20:06:12 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <CAFPFaMJTErRzCuA5RWAsfPmqUr9Hx22+4RuCH9NKKioVgf+3OA@mail.gmail.com>
Content-Type: multipart/alternative;
 boundary="------------91E3A0B1F6C6D77517705AF3"
Content-Language: en-US
Subject: Re: [PHP-DEV] PDO fetch performance problems with many bind
 parameters
From: dino.pejakovic@voxdiversa.hr (Dino Pejakovic)

--------------91E3A0B1F6C6D77517705AF3
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit

> Just that you are aware the emails from both of you went to my spam folder.
Thanks for the info. If anyone has any idea why we went to spam, please 
let us know.


The reason I didn't create a pull request immediately is that I don't 
have a concrete fix. The diff that I sent just shows where I commented 
out the lines to confirm this was the problem.

PDO_PARAM_EVT_FETCH_POST seems to be used by pdo_firebird so I can't 
just remove the hooks. Also, pdo_pgsql seems to be processing some kind 
of INPUT_OUTPUT parameters and parsing postgres bools. This is in a code 
path that is maybe still used while fetching:

|if (PDO_PARAM_TYPE(param->param_type) == PDO_PARAM_BOOL &&||
||            ((param->param_type & PDO_PARAM_INPUT_OUTPUT) != 
PDO_PARAM_INPUT_OUTPUT)) {||
||            const char *s = zend_is_true(&param->parameter) ? "t" : "f";||
||            param->param_type = PDO_PARAM_STR;||
||            zval_ptr_dtor(&param->parameter);||
||            ZVAL_STRINGL(&param->parameter, s, 1);||
||        }|

I'm not familiar with what this does so I wanted someone more familiar 
with PDO to see it first. I don't think I can create a useful pull 
request that doesn't break anything.


On 8/26/20 7:28 PM, G. P. B. wrote:
> Just that you are aware the emails from both of you went to my spam folder.
>
> Back to the matter, this is the correct list to email Dino, however could
> you
> open a pull request on GitHub for this change so that more eyes (and
> especially eyes from people which know PDO) can have a look?
>
> Please provide the relevant information again in the pull request and
> possibly host your files on a gist.
>
> This can still target PHP 8.0 as this seems to be akin to a bug this
> might even be applicable to PHP 7.3/7.4. Anyways, good catch.
>
> Best regards
>
> George P. Banyard
>

--------------91E3A0B1F6C6D77517705AF3--