Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111692
MIME-Version: 1.0
References: <73403328efaefb3141bf59dcab66d4859ee264fd691801fc7c23111c03ac02a7@mahalux.com>
 <CAF+90c9YX+C=rQVp0tJfCsk+dnMT1xgRbhBHP-y6a3Z5Z4qWUg@mail.gmail.com>
In-Reply-To: <CAF+90c9YX+C=rQVp0tJfCsk+dnMT1xgRbhBHP-y6a3Z5Z4qWUg@mail.gmail.com>
Date: Wed, 26 Aug 2020 09:16:12 +0100
Message-ID: <CALKiJKo_3Du482dft_44Q6fGVZsZSQm+fmzGFpQrW7QBNemrTA@mail.gmail.com>
To: PHP Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007b34f405adc36f9f"
Subject: Re: [PHP-DEV] Array map with reset function
From: rowan.collins@gmail.com (Rowan Tommins)

--0000000000007b34f405adc36f9f
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 25 Aug 2020 at 20:08, Nikita Popov <nikita.ppv@gmail.com> wrote:

> On Tue, Aug 25, 2020 at 7:47 PM Michael Vo=C5=99=C3=AD=C5=A1ek - =C4=8CVU=
T FEL <
> vorismi3@fel.cvut.cz> wrote:
>
> > The following code stopped working in PHP 8:
> >
> > https://3v4l.org/UlIE3



To be pedantic: it didn't stop working, it just started raising Warnings.
The return value of array_map remains the same.



>
> >
> > is it a bug or a feature?
> >
>
> This is an intentional change, if that's what you're asking. array_map() =
is
> not spec'd to pass by reference, so it doesn't.
>


As with many uses of reset(), this one doesn't really need to be by
reference, it's being used for its output. Unfortunately, array_value_first
failed at RFC [https://wiki.php.net/rfc/array_key_first_last#vote], so I
presume the recommended replacement code in the general case is this:

array_map(fn($x)=3D>$x[array_key_first($x)], $rows)

Of course for a list-style array like the example shown, it can be a lot
simpler:

array_map(fn($x)=3D>$x[0], $rows)

Regards,
--=20
Rowan Tommins
[IMSoP]

--0000000000007b34f405adc36f9f--