Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:111679 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 29767 invoked from network); 21 Aug 2020 22:56:41 -0000 Received: from unknown (HELO localhost.localdomain) (76.75.200.58) by pb1.pair.com with SMTP; 21 Aug 2020 22:56:41 -0000 To: internals@lists.php.net References: Date: Fri, 21 Aug 2020 22:58:38 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Posted-By: 87.81.129.66 Subject: Re: Should hash comments be deprecated? From: marandall@php.net (Mark Randall) Message-ID: On 21/08/2020 18:28, Theodore Brown wrote: > Since the #[] attribute syntax is currently winning the vote, [1] > it makes me wonder if the use of comments starting with # should be > deprecated. I've mentioned this myself in R11 a few times and was planning on bringing this up to a vote myself as soon as we started for 8.1 I think it makes perfect sense, there's no reason why we need both // and # and if #[] wins out as it looks like it will, that's even more reason to deprecate #. There's an easy upgrade path too with a perfect substitution, and so far as I can tell the only breakage would be if people were using external code to do pre-processor like operations such as using #start and #end as quasi-tags. Ideally, if we pass #[ ] we would deprecate # in the same version and put it on the fast-track to removal, but that would require an additional vote. Mark Randall