Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111654
MIME-Version: 1.0
Content-Type: multipart/alternative; boundary="=_a0fb66bbf73972670185c6f9c438410e"
Date: Thu, 20 Aug 2020 14:55:09 +0200
To: PHP internals <internals@lists.php.net>
In-Reply-To: <CAFPFaM+mC-WCcMwrm51TqbjiPZ10Czn7mDV=vjQqYUpsjwB3Uw@mail.gmail.com>
References: <6cfb77d4d511b5c591e7d7b5cc80199955123b2cd4276a5bca2327e4b02942db@mahalux.com>
 <CALKiJKpnzC_9foE0yqVC73iatke8+8Snk+wV4kH51oohBk7bpw@mail.gmail.com> <4a6d97c1-28e8-c6cb-e985-d32c5d056ec0@telia.com>
 <a2560584b445b7c6f614658c92a173b9f71c7dc271c66068494de6dda1868996@mahalux.com>
 <CAFPFaMKrdE6g9rjGvjkYhRc+B7+t3cA0Q73EEWpC-bmPTfP2-Q@mail.gmail.com> <CAFPFaM+mC-WCcMwrm51TqbjiPZ10Czn7mDV=vjQqYUpsjwB3Uw@mail.gmail.com>
Message-ID: <6580abc6e6d8d73f1722d3070ec5214c7d0ba13759b97c60eacf57cfbfae50ab@mahalux.com>
Subject: Re: [PHP-DEV] Allow sleep() to accept non-integer values
From: vorismi3@fel.cvut.cz (=?UTF-8?Q?Michael_Vo=C5=99=C3=AD=C5=A1ek_-_=C4=8CVUT_FEL?=)

--=_a0fb66bbf73972670185c6f9c438410e
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset=UTF-8; format=flowed

> Again, I personally don't understand why this could bypass the RFC process, as multiple people have already, me included, voiced their disagreement with this change.

This was proposed by Nikita Popov in his comment

> Secondly this change introduces another inconsistency, why can sleep accept a float but not usleep?

Nanosleep and microsleep functions are basically 1:1 of the underlaying
implementation. The updated sleep() is however now never worse than the
best sleep function available, thus we can use it also for
time_nanosleep and usleep php function and accept float. I will
implement it.

> If there is indeed a need for being able to specify a sleep in milliseconds I'd prefer the introduction of a msleep function then this change.

The issue I solve is sleep function that accepts seconds should accept
floating point values as time is continous value. 

With kind regards / Mit freundlichen Grüßen / S přátelským pozdravem,

Michael Voříšek

On 20 Aug 2020 14:25, G. P. B. wrote:

> Apologies for the double email, my client did something funcky. 
> 
> On Thu, 20 Aug 2020 at 14:22, G. P. B. <george.banyard@gmail.com> wrote: 
> 
> On Thu, 20 Aug 2020 at 14:15, Michael Voříšek - ČVUT FEL <vorismi3@fel.cvut.cz> wrote: Hi everyone, 
> 
> thank you for your comments, based on them, I fixed these: 
> 
> - usleep is now used as a fallback as well, if interrupted, remaining
> time is measured using microtime, so return value is always available 
> 
> - for BC, if not interrupted, return value remains to be 0 (integer
> zero) 
> 
> Now, the sleep() function should be really universal, cross platform and
> I would say also the prefered way to sleep. 
> 
> The implementaion is here https://github.com/php/php-src/pull/5961/files
> 
> Please comment on Github directly if you have any feedback left. 
> 
>> I thinkit's worth considering if this also should be fixed in 8.0 or even earlier ;-)So good to hear the RM view on this.
> 
> Sara, are you ok to include this in PHP 8.0 and do you require a RFC for
> it? 
> 
> With kind regards / Mit freundlichen Grüßen / S přátelským pozdravem,
> 
> Michael Voříšek

Again, I personally don't understand why this could bypass the RFC
process, 
as multiple people have already, me included, voiced their disagreement
with this change. 

Secondly this change introduces another inconsistency, why can sleep
accept a float but not usleep? 

If there is indeed a need for being able to specify a sleep in
milliseconds I'd prefer the introduction of a 
msleep function then this change. 

Best regards 

George P. Banyard
--=_a0fb66bbf73972670185c6f9c438410e--