Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111653
MIME-Version: 1.0
References: <6cfb77d4d511b5c591e7d7b5cc80199955123b2cd4276a5bca2327e4b02942db@mahalux.com>
 <CALKiJKpnzC_9foE0yqVC73iatke8+8Snk+wV4kH51oohBk7bpw@mail.gmail.com>
 <4a6d97c1-28e8-c6cb-e985-d32c5d056ec0@telia.com> <a2560584b445b7c6f614658c92a173b9f71c7dc271c66068494de6dda1868996@mahalux.com>
In-Reply-To: <a2560584b445b7c6f614658c92a173b9f71c7dc271c66068494de6dda1868996@mahalux.com>
Date: Thu, 20 Aug 2020 14:25:23 +0200
Message-ID: <CAP=4hCKJgHRdW5hNUPQ_MfxrfkYn4fDQ4kwfBXXCpn6cV0Oe6A@mail.gmail.com>
To: =?UTF-8?B?TWljaGFlbCBWb8WZw63FoWVrIC0gxIxWVVQgRkVM?= <vorismi3@fel.cvut.cz>
Cc: Sara Golemon <pollita@php.net>, PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000da530c05ad4e37da"
Subject: Re: [PHP-DEV] Allow sleep() to accept non-integer values
From: carusogabriel34@gmail.com (Gabriel Caruso)

--000000000000da530c05ad4e37da
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 20 Aug 2020 at 14:16, Michael Vo=C5=99=C3=AD=C5=A1ek - =C4=8CVUT FE=
L <
vorismi3@fel.cvut.cz> wrote:

> Hi everyone,
>
> thank you for your comments, based on them, I fixed these:
>
> - usleep is now used as a fallback as well, if interrupted, remaining
> time is measured using microtime, so return value is always available
>
> - for BC, if not interrupted, return value remains to be 0 (integer
> zero)
>
> Now, the sleep() function should be really universal, cross platform and
> I would say also the prefered way to sleep.
>
> The implementaion is here https://github.com/php/php-src/pull/5961/files
>
>
> Please comment on Github directly if you have any feedback left.
>
> > I thinkit's worth considering if this also should be fixed in 8.0 or
> even earlier ;-)So good to hear the RM view on this.
>
> Sara, are you ok to include this in PHP 8.0 and do you require a RFC for
> it?
>
> With kind regards / Mit freundlichen Gr=C3=BC=C3=9Fen / S p=C5=99=C3=A1te=
lsk=C3=BDm pozdravem,
>
> Michael Vo=C5=99=C3=AD=C5=A1ek
>
> On 11 Aug 2020 12:43, Bj=C3=B6rn Larsson wrote:
>
> > Den 2020-08-11 kl. 10:53, skrev Rowan Tommins:
> >
> > On Tue, 11 Aug 2020 at 08:31, Michael Vo=C5=99=C3=AD=C5=A1ek - =C4=8CVU=
T FEL <
> > vorismi3@fel.cvut.cz> wrote:
> >
> > I am the author of https://github.com/php/php-src/pull/5961 , please
> > provide feedback.
> >
> > This idea makes a lot of sense to me as a user (I'll leave comments on
> the
> > implementation to those with more C experience).
> >
> > I'm pretty sure I've accidentally written things like "sleep(1.5)" in t=
he
> > past, and think there is a strong argument for changing something here:
> >
> > Another reason is that sleep(0.1); is silently accepted now (even with
> strict types enabled), but the input is casted to 0 and thus producing
> > unexpected behaviour if the user is not aware of the current method
> > prototype.
> >
> > Unless there are problems with the implementation, this seems like a
> > straight-forward win.
> >
> > Regards,
>
> Given this unexpected behaviour, one could almost see it as a bug. I
> think
> it's worth considering if this also should be fixed in 8.0 or even
> earlier ;-)
> So good to hear the RM view on this.
>
> r//Bj=C3=B6rn L



I don't know about Sara's opinion here, but mine, as PHP 8.0's other
Release Manager, this change requires an RFC
and it should target PHP 8.1. PHP 8.0 has been feature frozen for a while
now.

--000000000000da530c05ad4e37da--