Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111619
To: Benjamin Eberlei <kontakt@beberlei.de>, Derick Rethans <derick@php.net>
CC: PHP Developers Mailing List <internals@lists.php.net>
Thread-Topic: [PHP-DEV] [RFC] Shorter Attribute Syntax Change RFC 0.2
Thread-Index: AQHWamWKUBRwNDrYsUOzfoBQKi8o6Kk+PgmAgABAhfw=
Date: Tue, 18 Aug 2020 22:03:32 +0000
Message-ID:
 <BYAPR05MB65352CF9ABDD8E58671C2216DE5C0@BYAPR05MB6535.namprd05.prod.outlook.com>
References:
 <alpine.DEB.2.23.453.2008041440380.7489@singlemalt.home.derickrethans.nl>,<CAEPJduk12mo-eizR=K7G9TdaMdk7=C5iq88QWwQ6B_tk02r=2w@mail.gmail.com>
In-Reply-To:
 <CAEPJduk12mo-eizR=K7G9TdaMdk7=C5iq88QWwQ6B_tk02r=2w@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [hgawkfV9VkMjqrQ8ahn8IYgaQhDlqGTG]
x-ms-publictraffictype: Email
x-incomingheadercount: 45
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: 31cd79dd-317c-4673-49ad-08d843c28c26
x-ms-traffictypediagnostic: BL0PR2101MB0994:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 2qVUaOuQtu49Z+1Q1Tdw0FSa+b78AZDcfpFQSzlTdg8gmk4lZIyQhYB0hKqw+vj50UpI14mLNsytsZitXlfPAEBOJWpR0NMsBFuG7waUuSIE1JPn7kb0Ud18mAv0V3AQMkVYoRpAaBZe3g5fHY5C/9zc7nNR646yElMPYsEYIU+lVoUukT+10KarovJXp89+K531H7Qx+1oc2EmKclHkq9u0zL6j8xsNwtBQtwKBFkD0Pz02/KM+ipcO6PYA7uT+
x-ms-exchange-antispam-messagedata:
 ohcdPJ4UEnEw2BzkJm9y2knEojwVtRbKYsrPUdFu0ppfGILpgtRiWIeA+n1e/vjPp5Qb08IW85YUlow3TzL/bWpqQkXWJ3ew6i68uA4k7/Updb0hRJnLWJX/alQ4qHsLuufBIMnaLX7Z35n1s0oeeQ==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: BN7NAM10FT034.eop-nam10.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 31cd79dd-317c-4673-49ad-08d843c28c26
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Aug 2020 22:03:32.5531
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR2101MB0994
Subject: Re: [PHP-DEV] [RFC] Shorter Attribute Syntax Change RFC 0.2
From: theodorejb@outlook.com (Theodore Brown)

On Tue, Aug 18, 2020 at 1:00 PM Benjamin Eberlei <kontakt@beberlei.de> wrot=
e:=0A=
=0A=
> https://wiki.php.net/rfc/shorter_attribute_syntax_change=0A=
> =0A=
> I have updated the RFC one last time with as much of the feedback=0A=
> as possible:=0A=
> =0A=
> - a section about comparing to complexity of type definitions=0A=
> - removal of the machine reading section as too narrow and =0A=
>   ultimately not that important as downstream libraries just have to=0A=
>   deal with any of it=0A=
> - some more nuances in forward compatibility pro/cons section of #[]=0A=
> - smaller corrections and improvements.=0A=
> =0A=
> I don't think something major is missing now.=0A=
=0A=
Hi Benjamin,=0A=
=0A=
Thanks for the updates. I just have a few more thoughts on aspects=0A=
that haven't been mentioned before:=0A=
=0A=
1. The **Attributes are not like Modifiers** section makes an=0A=
   argument that having an end delimiter "groups docblock comment and=0A=
   attributes into two similarly shaped syntax blocks that prefix the=0A=
   declaration increasing familiarity."=0A=
=0A=
In my own (admittedly subjective) opinion, an end delimiter on=0A=
attributes actually increases confusion when there is also a=0A=
docblock. To reuse the example from the RFC:=0A=
=0A=
    /**=0A=
     * A comment describing things.=0A=
     *=0A=
     * @psalm-suppress SomeRule=0A=
     */=0A=
    #[=0A=
        ORM\Entity(),=0A=
        ORM\Table("baz")=0A=
    ]=0A=
    final class Something {=0A=
    }=0A=
=0A=
Because the attribute group has its own start and end delimiters, it=0A=
almost looks like the doc comment applies to the attribute block=0A=
rather than the class.=0A=
=0A=
With the `@@` or `@:` syntax, it seems clearer that attributes are=0A=
part of the class/function/property declaration, rather than their=0A=
own standalone construct which docblocks can be applied to:=0A=
=0A=
    /**=0A=
     * A comment describing things.=0A=
     *=0A=
     * @psalm-suppress SomeRule=0A=
     */=0A=
    @@ORM\Entity=0A=
    @@ORM\Table("baz")=0A=
    final class Something {=0A=
    }=0A=
=0A=
=0A=
Given that the only complex part of an attribute is the optional=0A=
argument list, which already has its own start/end delimiters, I=0A=
ultimately don't find the "complexity" argument very compelling for=0A=
needing an additional attribute end delimiter besides.=0A=
=0A=
=0A=
2. In the **Discussion on grep'ability** section, the RFC says=0A=
   "Enforcement of same line is also not the case for other=0A=
   declarations that benefit from grep'ability such as classes,=0A=
   functions, constants and so on in PHP already, so this is not=0A=
   consistent within the language."=0A=
=0A=
This seems to be outdated information, based on Martin's original=0A=
patch before the "Treat namespaced names as single token" RFC was=0A=
accepted. In the current `@@` implementation, there is no single-line=0A=
enforcement, consistent with other parts of the language.=0A=
=0A=
Not having whitespace between the attribute token and name would be=0A=
enforced by coding style conventions, just as is the case with=0A=
function/class/constant definitions.=0A=
=0A=
Note that there is some precedent in PHP for choosing syntax that=0A=
ensures easier searching (for example, the decision to place return=0A=
type declarations after the parameter list rather than before the=0A=
function name).=0A=
=0A=
Grep'ability isn't a big deal when finding usages in an IDE, but=0A=
sometimes there is a need to search code on a server or other source=0A=
without an IDE, in which case easy grep'ability can be very helpful.=0A=
=0A=
Sincerely,  =0A=
Theodore=