Newsgroups: php.internals Path: news.php.net Xref: news.php.net php.internals:111614 Return-Path: Delivered-To: mailing list internals@lists.php.net Received: (qmail 93024 invoked from network); 18 Aug 2020 21:02:53 -0000 Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5) by pb1.pair.com with SMTP; 18 Aug 2020 21:02:53 -0000 Received: from php-smtp4.php.net (localhost [127.0.0.1]) by php-smtp4.php.net (Postfix) with ESMTP id 657BD1804AC for ; Tue, 18 Aug 2020 13:04:07 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,DOS_RCVD_IP_TWICE_B, SPF_HELO_PASS,SPF_PASS autolearn=no autolearn_force=no version=3.4.2 X-Spam-Virus: No X-Envelope-From: Received: from box.beccati.com (box.beccati.com [176.9.123.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by php-smtp4.php.net (Postfix) with ESMTPS for ; Tue, 18 Aug 2020 13:04:06 -0700 (PDT) Received: from authenticated-user (box.beccati.com [176.9.123.236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by box.beccati.com (Postfix) with ESMTPSA id C244D200284; Tue, 18 Aug 2020 22:04:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=beccati.com; s=mail; t=1597781044; bh=FTQxp4HlBadj1C1IWXikDr9TiB5PRClOV71wF6XDcDQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=EKv6tuA15KM0KkaHIOnV0vVNhaXNIDLylrtRLJj+brXcE5bcLyrbCPxzpYaoc8dzc RVW6XBBtQjnyoP289jrb5BrvRpdx67j9Hg6Zc903QKwMTYCuT2qxDawekkbt1uWRrV G45KuvDOPwz5D5gMR430PxKZRXSOGvfkUCgmsEkS+BsxH8AsK4UYkdmOv93aTphwsl Zkvyyc5DUwTKrDhsWZAVYkedefr9zVlzW1ady6CG7Q1BP641bc0sf/nGcyiQyrzv9F Bg8TIy/kiteRKe9MjZ5ixoCcNX0G7bX71y7llH0a8dVscEuSZZLVjIJbscYckdJ9mC K/I4AQbTteITQ== To: Rowan Tommins Cc: PHP Internals References: Message-ID: <0f9cbf1d-9db9-34f6-db01-beb81f73e137@beccati.com> Date: Tue, 18 Aug 2020 22:04:01 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Subject: Re: [PHP-DEV] HTTP/1.1 by default in PHP 8.0 From: php@beccati.com (Matteo Beccati) Hi Rowan, On 17/08/2020 18:36, Rowan Tommins wrote: > On Mon, 17 Aug 2020 at 16:21, Matteo Beccati wrote: >> >> FWIW, I've just been hit by https://bugs.php.net/bug.php?id=47021 in a >> SOAP response from a server using "Transfer-Encoding:> spaces>chunked". I see the bug is still open, although the comments to >> the PR hint to the fact that it should have been fixed. > > Thanks for the heads up; if you can manage to get a test case, I'll have > another look over it as soon as I have time. I've just pushed what I think is the fix to the last remaining instance of whitespace issues with HTTP headers, this time when parsing the SOAP response. The fix is fairly similar to the one you made in the http fopen wrapper. SOAP tests are passing and valgrind doesn't complain, but an extra set of eyes on my commit would be appreciated. The commit also close the bug report, which I think is good anyway. Cheers -- Matteo Beccati Development & Consulting - http://www.beccati.com/