Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111591
MIME-Version: 1.0
References: <20200817164539.Horde.kYUsO4nuFe1V_fbKiAC6n5E@cloud.rochette.cc>
In-Reply-To: <20200817164539.Horde.kYUsO4nuFe1V_fbKiAC6n5E@cloud.rochette.cc>
Date: Mon, 17 Aug 2020 20:14:11 +0300
Message-ID: <CABJDiht7zduex8r+cY1yJW=Pb3p74b-79S0bSqOMgdt8DcFWWg@mail.gmail.com>
To: Mathieu Rochette <mathieu@rochette.cc>
Cc: "PHP internals (internals@lists.php.net)" <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000ce8e5405ad15e634"
Subject: Re: [PHP-DEV] Constructor parent property promotion
From: lokrain@gmail.com (Lokrain)

--000000000000ce8e5405ad15e634
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 17 Aug 2020 at 19:46, Mathieu Rochette <mathieu@rochette.cc> wrote:

> Hi,
>
>
>
> I=E2=80=99m writing a message here to receive feedback on a two ideas rel=
ated to
> class constructors before going more in details with an RFC. I hope this =
is
> appropriate behavior for this list
>
>
>
> With the Constructor Property Promotion accepted in PHP 8, there=E2=80=99=
s a lot
> less of boilerplate when writing class constructors. I=E2=80=99m suggesti=
ng two
> additional ways of making thing even easier and I hope, readable.
>
>
>
> First: I=E2=80=99d like to be able to automatically transfer a constructo=
r
> property to its parent constructor. I=E2=80=99m thinking of something lik=
e that:
>
>
>
> ```php
>
> class MyCommand extends Command
>
> {
>
>    public function __construct(
>
>        private Connection $connection,

Why do you use visibility modifier inside here?

>
>
>        parent string $name,
>
>    ) {

C# has something like this ) : base($name)

>
>
>    }
>
> }
>
> ```
>
>
>
> This would be the equivalent of :
>
>
>
> ```php
>
> class MyCommand extends Command
>
> {
>
>    public function __construct(
>
>        private Connection $connection,
>
>        string $name,
>
>    ) {
>
>        parent::__construct($name);
>
>    }
>
> }
>
> ```
>
>
>
> The second idea is to make the constructor body optional, the first examp=
le
> would now be:
>
>
>
> ```php
>
> class MyCommand extends Command
>
> {
>
>    public function __construct(
>
>        private Connection $connection,
>
>        parent string $name,
>
>    )
>
> }
>
> ```
>
>
>
> This would call the parent constructor automatically even if no "parent"
> parameter are present. I could even see this enforced by linter to avoid
> having logic in the constructors.
>
>
>
> If there is interest I=E2=80=99d like to try writing an rfc and implement=
 it. I
> have not much knowledge of the php-src code but I hope this is a small
> enough change that I=E2=80=99ll be able to tackle. So, at that time if so=
meone is
> interested in mentoring this little project I=E2=80=99d appreciate it :)
>
>
>
>
>
> regards,
>
>
>
> Mathieu

--000000000000ce8e5405ad15e634--