Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111578
MIME-Version: 1.0
References: <alpine.DEB.2.23.453.2008100935570.7489@singlemalt.home.derickrethans.nl>
 <CAEPJdu=Nna+H10YW503isRuyYXA1DzV2+NduQLOVautO=PXrTQ@mail.gmail.com> <CAJvSBVPBdQ9NNd7gK3nCvunR_m9cH_5JubEYSOt3KXnE1LH2Zg@mail.gmail.com>
In-Reply-To: <CAJvSBVPBdQ9NNd7gK3nCvunR_m9cH_5JubEYSOt3KXnE1LH2Zg@mail.gmail.com>
Date: Mon, 17 Aug 2020 14:29:28 +0200
Message-ID: <CAEPJdunqCX1v_+VZo72TzahZWjeoE4gH2VKXk4fF5LWHNvZ4oQ@mail.gmail.com>
To: Peter Bowyer <reywob@php.net>
Cc: Derick Rethans <derick@php.net>, PHP Developers Mailing List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000009eb00f05ad11ecd4"
Subject: Re: [PHP-DEV] [VOTE] Shorter Attribute Syntax Change
From: kontakt@beberlei.de (Benjamin Eberlei)

--0000000000009eb00f05ad11ecd4
Content-Type: text/plain; charset="UTF-8"

On Mon, Aug 17, 2020 at 10:02 AM Peter Bowyer <reywob@php.net> wrote:

> On Sun, 16 Aug 2020 at 10:29, Benjamin Eberlei <kontakt@beberlei.de>
> wrote:
>
>> We have updated the RFC at
>> https://wiki.php.net/rfc/shorter_attribute_syntax_change with what we
>> think
>> covers all the discussion and arguments made in this and the previous
>> mailing list threads.
>>
>
> Thank you for putting in the work it took to revise the RFC. It's good. I
> now understand what the delimiters achieve.
>
> While I don't agree with the first point in "Forcing @@ Attributes to end
> with parenthesis does not solve issues" (in this new syntax I'd ban
> whitespace) I appreciate the point you are making, and it is sensible for
> consistency.
>
> I feel grep'ability has been played down, as unless
> @@
>     MyProject\FooAttr
>
> is allowed (which isn't shown in the codeblock), then it's easier to grep
> for @@.+?Foo and know you have a chance of an accurate match (assuming
> renaming is not used) than it is with the delimiter syntax.
>

no space is allowed between @@ and name, they have to be in the same line.
The whitespace between name and argument_list is not currently banned, the
comparison is to the status quo (since that is not expected to change).

Still I think the grepability has to rest on no assumptions, because
otherwise you could argue the same for @[] being used non-grouped on one
line and would have to conclude that this is also grepable.

>
> Sorry to everyone for causing this hazzle.
>>
>
> These things happen. Thank you for taking on-board the feedback and
> working on the RFC.
>
> Peter
>

--0000000000009eb00f05ad11ecd4--