Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111573
MIME-Version: 1.0
References: <C30D6E89-9521-4106-B55A-590CCD3F4986@joshbruce.dev> <747c6d622bbadebf32a8b7dec541c333eeb8776a6ab7ff0784a0b75c8895a646@mahalux.com>
In-Reply-To: <747c6d622bbadebf32a8b7dec541c333eeb8776a6ab7ff0784a0b75c8895a646@mahalux.com>
Date: Mon, 17 Aug 2020 10:17:44 +0100
Message-ID: <CALKiJKoaPA-8-Eb1ceoDvp6G_q-uVSJCG3tpbtj=VfXvW-sW=A@mail.gmail.com>
To: Internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="000000000000168c0705ad0f3ff4"
Subject: Re: [PHP-DEV] [Concept] Don't cast keys in array to int
From: rowan.collins@gmail.com (Rowan Tommins)

--000000000000168c0705ad0f3ff4
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Mon, 17 Aug 2020 at 05:19, Michael Vo=C5=99=C3=AD=C5=A1ek - =C4=8CVUT FE=
L <
vorismi3@fel.cvut.cz> wrote:

> This seems almost as a bug, strict types should apply also for array key
> which is currently not the case.
>
> https://3v4l.org/epv5s



No, it really shouldn't. In hindsight, "strict_types" was a bad name for
that directive; it is not a catch-all "make the type system stricter" flag,
it changes one specific piece of logic: when passing a scalar value to a
function parameter annotated with a different scalar type, should the value
be automatically cast, or require a manual cast. There is no function call
in that code example, so the directive has no effect.


The reason PHP treats $foo[42] as referring to the same element as
$foo['42'] is to support this straight-forwardly useful code:

$options =3D [
    1 =3D> 'apple',
    2 =3D> 'orange',
    3 =3D> 'banana',
    4 =3D> 'caramel',
];
$selected_option =3D $options[ $_GET['id'] ] ?? 'vanilla';


Casting between arrays and objects is a whole separate issue, and changed
in PHP 7.2; the RFC explains the issues quite well:
https://wiki.php.net/rfc/convert_numeric_keys_in_object_array_casts


Regards.
--=20
Rowan Tommins
[IMSoP]

--000000000000168c0705ad0f3ff4--