Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111569
MIME-Version: 1.0
References: <alpine.DEB.2.23.453.2008041440380.7489@singlemalt.home.derickrethans.nl>
 <CAEPJdumGf0r9Jwb9nBiAEFPoELP4ckx_OJo4HCHhAPgUPEMqQA@mail.gmail.com> <BYAPR05MB65352E2180151559DDFA1E91DE5F0@BYAPR05MB6535.namprd05.prod.outlook.com>
In-Reply-To: <BYAPR05MB65352E2180151559DDFA1E91DE5F0@BYAPR05MB6535.namprd05.prod.outlook.com>
Date: Mon, 17 Aug 2020 09:10:48 +0100
Message-ID: <CAJvSBVMf2q5t-AtpA7hYmJ-B_A4saTyAXW8qyrJuWAnGWeO41w@mail.gmail.com>
To: Theodore Brown <theodorejb@outlook.com>
Cc: Benjamin Eberlei <kontakt@beberlei.de>, Derick Rethans <derick@php.net>, 
	PHP Developers Mailing List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000006c37c05ad0e5145"
Subject: Re: [PHP-DEV] [RFC] Shorter Attribute Syntax Change RFC 0.2
From: phpmailinglists@gmail.com (Peter Bowyer)

--00000000000006c37c05ad0e5145
Content-Type: text/plain; charset="UTF-8"

On Mon, 17 Aug 2020 at 02:06, Theodore Brown <theodorejb@outlook.com> wrote:

> ## Forcing @@ attributes to end with parenthesis?
>
> I don't really see the point of this section in the RFC.


The blame for that is on me, not Benjamin and Derek, as I repeatedly asked
why a compulsory ) could not be considered a closing delimiter.


> ## Attribute nesting
>
> The RFC points out that all the syntaxes can allow attribute nesting,
> which is true. However, it would be nice to include an example of
> potential future nesting for each syntax, as was included in the
> original Shorter Attribute Syntax RFC. The reason is that some of the
> syntaxes are less readable than others when nested (particularly `<<>>`,
> though arguably `#[]` and `@[]` as well since the attribute end
> delimiter can be confused with the end bracket of an array argument.
>
>     @@JoinTable(
>         "User_Group",
>         @@JoinColumn("User_id", "id"),
>         @@JoinColumn("Group_id", "id"),
>     )
>     private $groups;
>
>     #[JoinTable(
>         "User_Group",
>         #[JoinColumn("User_id", "id")],
>         #[JoinColumn("Group_id", "id")],
>     )]
>     private $groups;
>
>     @[JoinTable(
>         "User_Group",
>         @[JoinColumn("User_id", "id")],
>         @[JoinColumn("Group_id", "id")],
>     )]
>     private $groups;
>
>     <<JoinTable(
>         "User_Group",
>         <<JoinColumn("User_id", "id")>>,
>         <<JoinColumn("Group_id", "id")>>,
>     )>>
>     private $groups;
>
>     @:JoinTable(
>         "User_Group",
>         @:JoinColumn("User_id", "id"),
>         @:JoinColumn("Group_id", "id"),
>     )
>     private $groups;
>

Good catch.

Peter

--00000000000006c37c05ad0e5145--