Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111449
MIME-Version: 1.0
References: <6cfb77d4d511b5c591e7d7b5cc80199955123b2cd4276a5bca2327e4b02942db@mahalux.com>
In-Reply-To: <6cfb77d4d511b5c591e7d7b5cc80199955123b2cd4276a5bca2327e4b02942db@mahalux.com>
Date: Tue, 11 Aug 2020 09:53:43 +0100
Message-ID: <CALKiJKpnzC_9foE0yqVC73iatke8+8Snk+wV4kH51oohBk7bpw@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000001c83fe05ac963678"
Subject: Re: [PHP-DEV] Allow sleep() to accept non-integer values
From: rowan.collins@gmail.com (Rowan Tommins)

--0000000000001c83fe05ac963678
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, 11 Aug 2020 at 08:31, Michael Vo=C5=99=C3=AD=C5=A1ek - =C4=8CVUT FE=
L <
vorismi3@fel.cvut.cz> wrote:

> I am the author of https://github.com/php/php-src/pull/5961 , please
> provide feedback.
>


This idea makes a lot of sense to me as a user (I'll leave comments on the
implementation to those with more C experience).

I'm pretty sure I've accidentally written things like "sleep(1.5)" in the
past, and think there is a strong argument for changing something here:

> Another reason is that sleep(0.1); is silently accepted now (even with
strict types enabled), but the input is casted to 0 and thus producing
unexpected behaviour if the user is not aware of the current method
prototype.

Unless there are problems with the implementation, this seems like a
straight-forward win.

Regards,
--=20
Rowan Tommins
[IMSoP]

--0000000000001c83fe05ac963678--