Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111422
To: internals@lists.php.net
References: <alpine.DEB.2.23.453.2008100935570.7489@singlemalt.home.derickrethans.nl>
Message-ID: <5c73b8d0-f477-83a0-4bd4-2fb8d11ad416@seld.be>
Date: Mon, 10 Aug 2020 13:32:13 +0200
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <alpine.DEB.2.23.453.2008100935570.7489@singlemalt.home.derickrethans.nl>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Subject: Re: [PHP-DEV] [VOTE] Shorter Attribute Syntax Change
From: j.boggiano@seld.be (Jordi Boggiano)

On 10/08/2020 10:41, Derick Rethans wrote:
> I've just opened the vote to make sure we don't make a terrible mistake
> with using the @@ syntax for attributes:
>
> https://wiki.php.net/rfc/shorter_attribute_syntax_change#voting
>

Here is a more detailed comparison of how this would look like in real 
use, adapted from some basic doctrine and symfony validation annotation 
I got somewhere:

https://gist.github.com/Seldaek/b7a3bd28920c6cc181e67a829b13a81c

I think something like this would belong in the RFC. I find that the 
grouping "feature" does not help that much, it's kinda hard to grasp 
what's going on. Proper syntax highlighting would surely help but still.

You may argue it's comparing in terms of looks, but as others have said 
I find it hard to compare them in other terms as the pros/cons listed in 
the RFC have a very limited impact for the most part, so yeah I feel 
like looks and readability should be at least somewhat taken into 
account too.

Best,
Jordi