Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111414
MIME-Version: 1.0
References: <CAGKNXQE0zgAc8Sq2=HQcQboSa+4dm6BqidpwDmRViqk26=LuHA@mail.gmail.com>
In-Reply-To: <CAGKNXQE0zgAc8Sq2=HQcQboSa+4dm6BqidpwDmRViqk26=LuHA@mail.gmail.com>
Date: Mon, 10 Aug 2020 09:37:25 +0200
Message-ID: <CAF+90c9APG=_gRWW+4nY-4WLLxKsUj1aHz5ZYgtLmCK+TRCBvQ@mail.gmail.com>
To: Philip Hofstetter <phofstetter@sensational.ch>
Cc: PHP internals <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000095125605ac810716"
Subject: Re: [PHP-DEV] ZEND_ENGINE_4 define?
From: nikita.ppv@gmail.com (Nikita Popov)

--00000000000095125605ac810716
Content-Type: text/plain; charset="UTF-8"

On Mon, Aug 10, 2020 at 7:57 AM Philip Hofstetter <
phofstetter@sensational.ch> wrote:

> Hello,
>
> I'm currently looking into porting some extensions (both internal and
> public) to PHP 8 while still keeping support for PHP 7 (for the public
> ones) and PHP 5.6 (don't ask :-().
>
> In many cases, I've been using the ZEND_ENGINE_3 define to handle the
> PHP 5/7 difference.
>
> Now, the Zend Engine version seems to have been increased to 4 (which
> feels warranted given the zval* to zend_object* changes for object
> handlers), but ZEND_ENGINE_3 is still defined whereas there's no
> ZEND_ENGINE_4.
>
> Is this something that might change or should I just use
> PHP_VERSION_ID comparisons to deal with the zval* to zend_object*
> changes?
>
> Philip
>

I would recommend using PHP_VERSION_ID.

I have no idea why we have the ZEND_ENGINE_3 constant, but it seems like a
pretty bad idea. Now that we are at ZE 4, should we drop that constant --
and break all the code using it? Chances are that code guarded by
ZEND_ENGINE_3 is also needed on all versions of ZE going forward, not just
ZE 3 in particular. I think we should just leave teh ZEND_ENGINE_3 define
around, but make sure not to introduce a new one of that kind.

Regards,
Nikita

--00000000000095125605ac810716--