Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111412
Return-Path: <phofstetter@sensational.ch>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 8395 invoked from network); 10 Aug 2020 06:57:30 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 10 Aug 2020 06:57:30 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id 2DD6D1804D9
	for <internals@lists.php.net>; Sun,  9 Aug 2020 22:56:36 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
	RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_PASS autolearn=no
	autolearn_force=no version=3.4.2
X-Spam-Virus: No
X-Envelope-From: <phofstetter@sensational.ch>
Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by php-smtp4.php.net (Postfix) with ESMTPS
	for <internals@lists.php.net>; Sun,  9 Aug 2020 22:56:35 -0700 (PDT)
Received: by mail-wr1-f44.google.com with SMTP id p20so6962702wrf.0
        for <internals@lists.php.net>; Sun, 09 Aug 2020 22:56:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=sensational.ch; s=google;
        h=mime-version:from:date:message-id:subject:to;
        bh=qnYTgDAsPsfILxHbxkbw/rlkXUA9LtPF8EY1PvmdqJQ=;
        b=vkTkHUcYz9KfiGCq/znK1iVkz2tRzVLlNlBM+X3v54skXTFukCyN/znRRwMLAdmQfH
         d8H5SvwKjN2NXsVmRbd7JmS8AVC9RzztbPUK8ua7EqzVusiEh5C8aNRT13PNVfQzksZu
         vWwHyuToQ3foDjBZGbRXrmb4yWYNAsZdDYbXZMBfdtMlQpsBpzmkmliifvpMLGX/40NE
         zzi5FGOsBlkdLqo3mx16uvJ8y0jzOvm5uwuh+QKA4pBuoqzrjzJWUX1bjK7+FHHCpmmS
         npHG9ZKgpB0IlicJ3rkttMCvkRLtvY7X4w2HoC64bw2k9r73y8z5K8zO3+1oqHsqsGVa
         wGWw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:from:date:message-id:subject:to;
        bh=qnYTgDAsPsfILxHbxkbw/rlkXUA9LtPF8EY1PvmdqJQ=;
        b=nLbxnDfrxa61QAIoVphHPNa8cfZnOKGXT/XAAZJaO0yXqOgBc7yth6b04kad94w+K/
         audpVG7woVUxZGRqi5N4O1pt9VFCtjJEGUxyx1uK5Sy8UYz5MWPgY8m3MmJfuzjEDpD5
         x895+ONI+Km06Q8AWv2xniB7xX8BjDcKdhxDLIOjjzouBKQ/yhKEVM7X9q9Y143mBx86
         v7xP455X8ZxoCizoHCOG3JwyUOxYr9LqrhYvGtDEShfO2nn7zmS63PoxcxMf+WtskVWX
         nUDJhgsI+fgGPEllkNkVN6mX6rA2GwyxDsK9FrLGbT9G9yg9qWWAfnSgvI/KX54dcaNk
         YeBg==
X-Gm-Message-State: AOAM530TG/nrg8CmxL/UOo4VALZ3HkLBoqJMVBKDE5k/p2WtsWzjyd+I
	w6Cwe5kYY49x+L2zEPxRMFAKl97l/Q/JmOQ3HlSJRKvxFzhgUg==
X-Google-Smtp-Source: ABdhPJz171LwqOf2Hp38ApgV5LzxGMFEd4NOl0vwg9iVcvVUb76+itagz0OQ3P5hXZyTMQWlog8ECMZBAyl7hlG1r/o=
X-Received: by 2002:a5d:4610:: with SMTP id t16mr24105190wrq.101.1597038991473;
 Sun, 09 Aug 2020 22:56:31 -0700 (PDT)
MIME-Version: 1.0
Date: Mon, 10 Aug 2020 07:56:20 +0200
Message-ID: <CAGKNXQE0zgAc8Sq2=HQcQboSa+4dm6BqidpwDmRViqk26=LuHA@mail.gmail.com>
To: PHP internals <internals@lists.php.net>
Content-Type: text/plain; charset="UTF-8"
Subject: ZEND_ENGINE_4 define?
From: phofstetter@sensational.ch (Philip Hofstetter)

Hello,

I'm currently looking into porting some extensions (both internal and
public) to PHP 8 while still keeping support for PHP 7 (for the public
ones) and PHP 5.6 (don't ask :-().

In many cases, I've been using the ZEND_ENGINE_3 define to handle the
PHP 5/7 difference.

Now, the Zend Engine version seems to have been increased to 4 (which
feels warranted given the zval* to zend_object* changes for object
handlers), but ZEND_ENGINE_3 is still defined whereas there's no
ZEND_ENGINE_4.

Is this something that might change or should I just use
PHP_VERSION_ID comparisons to deal with the zval* to zend_object*
changes?

Philip