Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111334
To: Derick Rethans <derick@php.net>, PHP Developers Mailing List
	<internals@lists.php.net>
Thread-Topic: [PHP-DEV] [RFC] Shorter Attribute Syntax Change RFC 0.2
Thread-Index: AQHWamWPHsqLR0j+3kKp37krfiTdR6koudCk
Date: Wed, 5 Aug 2020 01:57:37 +0000
Message-ID:
 <DM6PR07MB6618AD98A48F7467D98FB1FDF94B0@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <alpine.DEB.2.23.453.2008041440380.7489@singlemalt.home.derickrethans.nl>
In-Reply-To:
 <alpine.DEB.2.23.453.2008041440380.7489@singlemalt.home.derickrethans.nl>
Accept-Language: en-CA, en-US
Content-Language: en-CA
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [zkcDYHnZ1qw29o7W/V0fP/Kr0Q8M9Rj7MDG/ZDfdqG2oQLgsyr1dneg0j99oeczt]
x-ms-publictraffictype: Email
x-incomingheadercount: 44
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: d72b37b7-4095-4890-f0ad-08d838e2ed80
x-ms-traffictypediagnostic: MW2NAM12HT245:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 zolFS7Y0xhDvLNKEB4EKDhXymWbEsxitjGkdwQdV0c1gjLYQPoDdbM+Ncq9R/XQsCcECzV9/U7wo3dwh0ICfwd7u+QBphJ+oOxvv62x7t8FxBo/R0Y3iEWPeGDp/C0aaDePyM3MidB0FE/U2PRcfGEeoRbjWUuF5mH3ml4J7CNgWNa5tmsJ3DwII7ZJiQnyTGxlk51081wxdNj6Pm5hCq/UNdAe/OegWmuMezx+frLahRitAfpuZ+xJOdnAL9Lb0
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR07MB6618.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901;
x-ms-exchange-antispam-messagedata:
 G8bcHNsNIDeXyZoA1ZIUf4XeUrcVIzwsh/XsczwITMdQ74Tv1xIbA7f5rDazy1G4RpaE/SIhDT8CaJkzmZSxIv8G7NJQFLe4+jbCO+49t1ciZt4tR8IggTApB06spPfd8R7xxZoOdkS0IYVtn4QXFHnymVCE6pbBw1+sK2MLUW5E13WIilju390N3VJ4RmyP0NAVBnuB2pXv95eI184KVw==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: MW2NAM12FT028.eop-nam12.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: d72b37b7-4095-4890-f0ad-08d838e2ed80
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Aug 2020 01:57:37.0600
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW2NAM12HT245
Subject: Re: [PHP-DEV] [RFC] Shorter Attribute Syntax Change RFC 0.2
From: tysonandre775@hotmail.com (tyson andre)

Hi Derick,=0A=
=0A=
> Out of Banjamin's suggestion[1], I've updated the Shorter Attribute =0A=
> Syntax Change RFC to reflect that process:=0A=
> =0A=
> https://wiki.php.net/rfc/shorter_attribute_syntax_change=0A=
> =0A=
> Patches and comments welcome.=0A=
=0A=
1. I feel like "Changes the lexing of **remaining** tokens" should also be =
included in the table following it - that's a major difference between `#[`=
(Yes) and each of the other proposals (No).=0A=
    The last time a substantial lexing change (that affected the following =
tokens, not just the tokens in question) happened was https://wiki.php.net/=
rfc/flexible_heredoc_nowdoc_syntaxes , but flexible heredoc is rare in prac=
tice and a project using it would almost always need to drop support for 7.=
2.=0A=
    I expect attributes to be used much, much more frequently than flexible=
 heredoc, and to break in subtler ways.=0A=
    Projects such as php-parser would be affected by the change to lexing, =
and would either have to force users to specify the php major version or to=
 always emulate 8.0's lexing if `#[` was encountered in a T_COMMENT token.=
=0A=
=0A=
    My earlier objections to `#[` were https://externals.io/message/111218#=
111239=0A=
=0A=
    To add to that, the benefit of forwards compatibility is also a drawbac=
k in some ways for the next few years (or longer, if you include OSes that =
unofficially backport security patches)=0A=
    A developer running php7 could run `php --syntax-check` locally on a fi=
le containing attributes=0A=
    and assume it'd work in php 8 when deployed to a php 8 environment or w=
hen publishing a library to packagist.=0A=
    (e.g. `#[DeprecationReason('This won't work because X')]` has a single =
quote after `won` terminating a string literal, resulting in a parse error =
only affecting php 8)=0A=
=0A=
    Better tooling would help to avoid that, but better tooling isn't unive=
rsal.=0A=
2. This RFC mentions objections to `@@` but not objections to other syntaxe=
s.=0A=
    Summarizing/Linking the main arguments for/against all 4+ proposed synt=
axes in an appendix of the RFC (with some reasonable length limit) would he=
lp in making an informed vote.=0A=
=0A=
    There have been over 50 emails so far in https://externals.io/message/1=
11300 and https://externals.io/message/111312=0A=
=0A=
Thanks,=0A=
- Tyson=