Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111291
MIME-Version: 1.0
References: <CAM0Ccxi7T+T=18YjtQX44j3Rh2S+m09zL+ypmvP0VYjt-CsvyQ@mail.gmail.com>
In-Reply-To: <CAM0Ccxi7T+T=18YjtQX44j3Rh2S+m09zL+ypmvP0VYjt-CsvyQ@mail.gmail.com>
Date: Mon, 3 Aug 2020 06:04:58 +0200
Message-ID: <CADyq6sKKAotECdg=8oQ-BjKQesgL1=aUsXEavOTwXw2GQ2jPYA@mail.gmail.com>
To: 3u93n3 <zsidelnik@gmail.com>
Cc: tandre@php.net, kriscraig@php.net, danielc@php.net, derick@php.net, 
	nikic@php.net, joe@joeferguson.me, internals@lists.php.net
Content-Type: multipart/alternative; boundary="000000000000ac5ba105abf13ef9"
Subject: Re: [PHP-DEV] Feature Request: dependencies container
From: ocramius@gmail.com (Marco Pivetta)

--000000000000ac5ba105abf13ef9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Heya,

On Mon, Aug 3, 2020, 05:32 3u93n3 <zsidelnik@gmail.com> wrote:

> The main idea is to take control over objects creation and injecting
> dependencies.
>
> 1. Some of them are provided through constructor (those, which could only
> be retrieved right before instantiating our object).
> 2. Others are provided through `__inject` and PHP will inject all those
> dependencies automatically. Configuration we define in separate class, an=
d
> pass it's instance into function-helper.
>

Overall, I don't think this is a good candidate for php-src 2 primary
reasons:

 1. This is already possible in userland: you can already define your own
`__inject` method, and, convention-based, rely on it in your own userland
DIC
 2. Setter injection (as well as property injection, and also the proposed
`__inject`) leads to temporal coupling smells. Explained otherwise, your
object instances are not "functioning" right after instantiation, which
makes their API more complex and reduces reliability (they are broken until
injection has happened). Please just use the constructor: it works, and it
is a simple pre-existing injection point =F0=9F=91=8D

--000000000000ac5ba105abf13ef9--