Newsgroups: php.cvs,php.internals
Path: news.php.net
Xref: news.php.net php.cvs:112396 php.internals:111203
Return-Path: <derick@php.net>
Delivered-To: mailing list internals@lists.php.net
Received: (qmail 35480 invoked from network); 27 Jul 2020 23:58:08 -0000
Received: from unknown (HELO php-smtp4.php.net) (45.112.84.5)
  by pb1.pair.com with SMTP; 27 Jul 2020 23:58:08 -0000
Received: from php-smtp4.php.net (localhost [127.0.0.1])
	by php-smtp4.php.net (Postfix) with ESMTP id 2C52018050B;
	Mon, 27 Jul 2020 15:53:56 -0700 (PDT)
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on php-smtp4.php.net
X-Spam-Level: 
X-Spam-Status: No, score=-1.1 required=5.0 tests=BAYES_00,SPF_HELO_PASS,
	SPF_NEUTRAL autolearn=no autolearn_force=no version=3.4.2
X-Spam-Virus: No
X-Envelope-From: <derick@php.net>
Received: from xdebug.org (xdebug.org [82.113.146.227])
	by php-smtp4.php.net (Postfix) with ESMTP;
	Mon, 27 Jul 2020 15:53:55 -0700 (PDT)
Received: from [10.65.250.202] (unknown [148.252.133.123])
	by xdebug.org (Postfix) with ESMTPSA id 7205710C068;
	Mon, 27 Jul 2020 23:53:54 +0100 (BST)
Date: Mon, 27 Jul 2020 23:53:52 +0100
User-Agent: K-9 Mail for Android
In-Reply-To: <php-mail-5bbfc55512e1bc8bf0efc450dec51740886647479@git.php.net>
References: <php-mail-5bbfc55512e1bc8bf0efc450dec51740886647479@git.php.net>
MIME-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: quoted-printable
To: php-cvs@lists.php.net,Benjamin Eberlei <beberlei@php.net>
CC: internals@lists.php.net
Message-ID: <8D7A8612-37B7-466B-B0EC-A7E02BE18E78@php.net>
Subject: Re: [PHP-CVS] com php-src: Consolidate Parameter Names For ext/simplexml: ext/simplexml/simplexml.stub.php ext/simplexml/simplexml_arginfo.h
From: derick@php.net (Derick Rethans)

On 27 July 2020 20:42:33 BST, Benjamin Eberlei <beberlei@php=2Enet> wrote:
>Commit:    eaeceb32932026c08a9d9e5be56da8e8111c5caa
>Author:    Benjamin Eberlei <kontakt@beberlei=2Ede>         Mon, 27 Jul
>2020 19:32:00 +0200
>Parents:   8a6bc6767dbda4861b83fb9dcbba4453e541bbb9
>Branches:  master
>
>Link:     =20
>http://git=2Ephp=2Enet/?p=3Dphp-src=2Egit;a=3Dcommitdiff;h=3Deaeceb329320=
26c08a9d9e5be56da8e8111c5caa
>
>Log:
>Consolidate Parameter Names For ext/simplexml
>
>Co-authored-by: Thomas Weinert <thomas@weinert=2Einfo>
>
>Changed paths:
>  M  ext/simplexml/simplexml=2Estub=2Ephp
>  M  ext/simplexml/simplexml_arginfo=2Eh
>
>
>Diff:
>diff --git a/ext/simplexml/simplexml=2Estub=2Ephp
>b/ext/simplexml/simplexml=2Estub=2Ephp
>index 2922adce4b=2E=2Ed3e48b0e6a 100644
>--- a/ext/simplexml/simplexml=2Estub=2Ephp
>+++ b/ext/simplexml/simplexml=2Estub=2Ephp
>@@ -2,19 +2,19 @@
>=20
> /** @generate-function-entries */
>=20
>-function simplexml_load_file(string $filename, ?string $class_name =3D
>SimpleXMLElement::class, int $options =3D 0, string $ns =3D '', bool
>$is_prefix =3D false): SimpleXMLElement|false {}
>+function simplexml_load_file(string $filename, ?string $class_name =3D
>SimpleXMLElement::class, int $options =3D 0, string $namespace_or_prefix
>=3D '', bool $is_prefix =3D false): SimpleXMLElement|false {}


I thought we were using studlyCaps, so that should be isPrefix and namespa=
ceOrPrefix?=20

cheers,
Derick