Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111192
To: Chris Riley <t.carnage@gmail.com>, PHP internals <internals@lists.php.net>
Thread-Topic: [PHP-DEV] Re: [RFC][Proposal] Renamed parameters
Thread-Index: AQHWY1QGV6S1Us1HE06xDv4fiLJYpKkZ/voK
Date: Sun, 26 Jul 2020 16:37:14 +0000
Message-ID:
 <DM6PR07MB66184897F26C66D5E86DAAB7F9750@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <CABHuAWx16_6rwye6BC4gUctSEdTTV0bq68S=1znNPykwGzXTsQ@mail.gmail.com>,<CABHuAWwETC=oJ4TWdkZ8sEW1ZbMp08YAZj3HMhH9UqG0J=eoxw@mail.gmail.com>
In-Reply-To:
 <CABHuAWwETC=oJ4TWdkZ8sEW1ZbMp08YAZj3HMhH9UqG0J=eoxw@mail.gmail.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [7mhpNAcdq2ovnkoaa+B7Jv5hjzQR7qwXq2CVDJMsPbE24W4YYWj8j8wZPom8NGm+]
x-ms-publictraffictype: Email
x-incomingheadercount: 44
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: c277b3dc-fe92-4f70-fe7b-08d831822703
x-ms-traffictypediagnostic: DM6NAM10HT060:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 orq2P2r+iDZM+5qZl0IG/0ZX1CkqC4G1E9RWmbvfJ7mwLrUyYd1ehQ75JiMSLez/Oe6RfLscljqQmFHz1A0OcnKw+l7pCfbR8tlgDt2KSS4u2B2TMLwbam/NCbar+H/sIm+/f7Dz82yOS20NHlVdE76ZOWVS8gOz49n5stP1TQCEYUnMfEVMzEq3I+7n0ZpZ8BWlQKYuT5r4eUikqZHTrxKHy1uC+N2w9LmF1EfX9lJsVfySFUau/vQGB4OEVACv
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR07MB6618.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901;
x-ms-exchange-antispam-messagedata:
 KBef0kK8rnQFpf1Os5bI+Oy5O1sojUTU/SURw4ujsxIhfA4zsKCtkZ5rTAh7ziLBn7YPXZTtCdbIYsFS6v1WQ9fAXHIgJJjBktfYzZolltwb31TZqPR7XfpXqv/PErX4JN4BhMqo3eMN6a7Fm1s0X4NRbEX2iXOJQSg1PUrnlXY1tCeZCwhjBIlRVKaWtdx/mcND67rcowpBKdkHd+2bzg==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: DM6NAM10FT010.eop-nam10.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: c277b3dc-fe92-4f70-fe7b-08d831822703
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2020 16:37:14.2108
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6NAM10HT060
Subject: Re: [PHP-DEV] Re: [RFC][Proposal] Renamed parameters
From: tysonandre775@hotmail.com (tyson andre)

Hi Chris Riley,=0A=
=0A=
I agree with Rowan Tommin's arguments in https://externals.io/message/11116=
1#111179 - I wanted named parameters by default.=0A=
=0A=
Miscellaneous comments:=0A=
=0A=
1. https://wiki.php.net/rfc/renamed_parameters should be moved to "In Discu=
ssion" on https://wiki.php.net/rfc/=0A=
2. I think that the RFC title should really mention "Making named parameter=
s opt-in",=0A=
   since that part of the RFC has the largest impact.=0A=
   (e.g. "Renamed parameters and making named parameters opt-in").=0A=
   (The RFC URL should not be changed)=0A=
3. For your examples, I assume you mean "Class Bar extends Foo {" instead o=
f "class Bar {"=0A=
4. "Error: cannot call parameter $externalName by name." seems incorrect,=
=0A=
    I assume "cannot call callBar() with parameter $externalName by name" o=
r something along those lines was intended=0A=
5. https://wiki.php.net/rfc/renamed_parameters#attributes still mentions "o=
ption 1" and "option 2", but those were removed from the current version of=
 the proposal, making this confusing=0A=
6. How will this RFC expect internal functions such as substr_compare() or =
internal methods such as `ArrayObject::__construct()` included in php-src?=
=0A=
=0A=
   What about PECLs - will existing function declaration macros be treated =
as opted out of or into named parameters?=0A=
7. This is missing some details on how reflection and backtrace generation =
will be affected.=0A=
   I assume `ReflectionParameter->getInternalName(): string`, `ReflectionPa=
rameter->getExternalName(): ?string`, etc. will need to be added.=0A=
   getTrace() and getTraceAsString()=0A=
8. Renaming parameters offers only a small performance benefit and I don't =
think it would get used very frequently.=0A=
    It's possible to add `$newName =3D $oldName; unset($oldName);` (or in m=
ost cases, to update the method implementation body).=0A=
9. Are declarations such as `function test($:publicName, $nonPublicName) {}=
` an error?=0A=
=0A=
   I'd personally prefer https://wiki.php.net/rfc/named_params#positional-o=
nly_and_named-only_parameters to allow API designers to explicitly opt out =
of named parameters.=0A=
10. As Rowin Tommins had said, "maintainers of larger OSS projects" is a br=
oad claim and could be clarified=0A=
   (e.g. what fraction of maintainers? Were there polls/discussion threads =
of maintainers/owners of OSS projects?)=0A=
=0A=
Since there are strong objections from some maintainers of supporting alway=
s-enabled named parameters,=0A=
I'd think a useful alternative would be to add a positional-only parameter =
syntax instead in 8.0, similar to what Python,=0A=
so that maintainers that want to avoid supporting named parameters in their=
 API can clearly express that in a release requiring ^8.0.=0A=
This is using syntax for https://www.python.org/dev/peps/pep-0570/#history-=
of-positional-only-parameter-semantics-in-python for clarity,=0A=
but obviously other syntax might suit PHP better.=0A=
(mentioned in https://wiki.php.net/rfc/named_params#positional-only_and_nam=
ed-only_parameters)=0A=
=0A=
```=0A=
function test(int $x, /, string $y) {}=0A=
test(x: 1, y: "test");  // Error: test() does not support being called with=
 parameter $x by name=0A=
test(1, y: "test");  // allowed=0A=
function test_varargs(...$args, /) {}=0A=
test_varargs(x: 1);  // Error: test_varargs() does not support being called=
 with named variable argument $x in ...$args=0A=
test_varargs(...['x' =3D> 1]);  // Error: test_varargs() does not support b=
eing called with named variable argument $x in ...$args=0A=
```=0A=
=0A=
There may be concerns such as whether `/` can be added when overriding,=0A=
or in forbidding using `...$newArgs, /` to override `...$originalArgs`=0A=
but since parameter renaming was already allowed in the Named Arguments RFC=
 this should not be a new issue.=0A=
=0A=
Regards,=0A=
- Tyson=