Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111145
To: tyson andre <tysonandre775@hotmail.com>, Derick Rethans <derick@php.net>,
 PHP Developers Mailing List <internals@lists.php.net>
References: <alpine.DEB.2.23.453.2007221247530.7489@singlemalt.home.derickrethans.nl>
 <DM6PR07MB661873706B57603ECBDE9D7EF9790@DM6PR07MB6618.namprd07.prod.outlook.com>
Message-ID: <a4e1bf4d-3fb2-0b3d-8f1b-cf1a6d54f910@beccati.com>
Date: Thu, 23 Jul 2020 09:37:18 +0200
MIME-Version: 1.0
In-Reply-To: <DM6PR07MB661873706B57603ECBDE9D7EF9790@DM6PR07MB6618.namprd07.prod.outlook.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [PHP-DEV] The @@ is terrible, are we sure we're OK with it?
From: php@beccati.com (Matteo Beccati)

Hi,

On 22/07/2020 19:09, tyson andre wrote:
> I think that `#[` has its own issues, but am open to re-voting on it.
> For example, the following snippet would get parsed differently in PHP 7.4 and PHP 8.0, given a hypothetical JIT annotation for Opcache.
> With <<Opcache\Jit>>, it would give people a clear indication that the file required PHP 8.0,
> but a one-line annotation might be silently treated differently in many subtle ways in 7.4.
> It's probably possible to amend the parser make it an error to put the function declaration on the same line or to have other `#` comments
> within a multi-line #[ annotation,
> but I really dislike the special casing it would add.

This is pretty much the reason why I didn't go for '#[' as my first
choice: the false sense of backwards compatibility that can be easily
(and inadvertently) defeated with multiline attributes or inline
function definition.

Since '@@' is causing such unrest, I'd be happy to revisit my choice and
embrace '#[', which was the second option in my vote.


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/