Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111089
MIME-Version: 1.0
References: <CABdc3WpEmoKTYEsDk+K1Jb=kh7nu8gJ3TkhY5639ueJaWjN9AQ@mail.gmail.com>
 <CABdc3WrNcPdY03d5oyUSW5nwaTkqd_wGscf2kWwxhD2ykPzRYA@mail.gmail.com>
 <DM6PR07MB6618D57BE5B6E246EA112CB8F9780@DM6PR07MB6618.namprd07.prod.outlook.com>
 <CABdc3WqOZ0UzN36yGMPAZ+3YkZ9jzwv=qZT3swz89kfp2kLDTw@mail.gmail.com>
 <DM6PR07MB6618A78F08DC09C2B83D792BF9780@DM6PR07MB6618.namprd07.prod.outlook.com>
 <CABdc3WpVq1ypfkoiNPxVEhMo+9PhJtwH2T1ay9=i3Ji75ae_Yg@mail.gmail.com>
In-Reply-To: <CABdc3WpVq1ypfkoiNPxVEhMo+9PhJtwH2T1ay9=i3Ji75ae_Yg@mail.gmail.com>
Date: Tue, 21 Jul 2020 10:41:39 +0200
Message-ID: <CAF+90c-dtf7COYSUxUPg_Ts5i4wKemi7VQ6d+Ax10QsQmkP4SQ@mail.gmail.com>
To: =?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?= <michal.brzuchalski@gmail.com>
Cc: tyson andre <tysonandre775@hotmail.com>, PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="0000000000007ec3ec05aaef98e9"
Subject: Re: [PHP-DEV] Re: [RFC][DISCUSSION] debug_backtrace alternative as an
 array of StackFrame objects
From: nikita.ppv@gmail.com (Nikita Popov)

--0000000000007ec3ec05aaef98e9
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jul 21, 2020 at 7:14 AM Micha=C5=82 Marcin Brzuchalski <
michal.brzuchalski@gmail.com> wrote:

> wt., 21 lip 2020 o 07:07 tyson andre <tysonandre775@hotmail.com>
> napisa=C5=82(a):
>
> > > Can you give an example of an internal stack frame?
> >
> > A stack frame that was created by a PHP internal function instead of by
> > userland code, i.e. one without a file in the frame.
> > Related to
> > https://github.com/php/php-src/pull/5820#pullrequestreview-452080212
> >
> >
> > ```
> > php > array_map(fn() =3D> $GLOBALS['x'] =3D StackFrame::getTrace()[0], =
[2]);
> > php > var_export($x);
> > StackFrame::__set_state(array(
> >    'file' =3D> NULL,
> >    'line' =3D> NULL,
> >    'function' =3D> '{closure}',
> >    'class' =3D> NULL,
> >    'type' =3D> NULL,
> >    'object' =3D> NULL,
> >    'object_class' =3D> NULL,
> >    'closure' =3D> NULL,
> >    'args' =3D>
> >   array (
> >     0 =3D> 2,
> >   ),
> > ))
> > ```
> >
>
> The RFC has been adjusted regarding the nullability of file and line
> properties and related getter methods.
>
> Is there anything else stopping it from getting up to the vote?
>
> Cheers,
> Micha=C5=82
>

Why does StackFrame define both public typed properties *and* getter
methods? One or the other would make sense to me, but not both.

Nikita

--0000000000007ec3ec05aaef98e9--