Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111085
MIME-Version: 1.0
References: <CABdc3WpEmoKTYEsDk+K1Jb=kh7nu8gJ3TkhY5639ueJaWjN9AQ@mail.gmail.com>
 <CABdc3WrNcPdY03d5oyUSW5nwaTkqd_wGscf2kWwxhD2ykPzRYA@mail.gmail.com>
 <DM6PR07MB6618D57BE5B6E246EA112CB8F9780@DM6PR07MB6618.namprd07.prod.outlook.com>
 <DM6PR07MB6618A906A660A00C1B7416D7F9780@DM6PR07MB6618.namprd07.prod.outlook.com>
In-Reply-To: <DM6PR07MB6618A906A660A00C1B7416D7F9780@DM6PR07MB6618.namprd07.prod.outlook.com>
Date: Tue, 21 Jul 2020 07:02:14 +0200
Message-ID: <CABdc3WpGnuJEwrrVHKS-0T-vzEheyv9jzo6rz3ck17FXDRPd6g@mail.gmail.com>
To: tyson andre <tysonandre775@hotmail.com>
Cc: PHP Internals List <internals@lists.php.net>
Content-Type: multipart/alternative; boundary="00000000000088e1bf05aaec8762"
Subject: Re: [PHP-DEV] Re: [RFC][DISCUSSION] debug_backtrace alternative as an
 array of StackFrame objects
From: michal.brzuchalski@gmail.com (=?UTF-8?Q?Micha=C5=82_Marcin_Brzuchalski?=)

--00000000000088e1bf05aaec8762
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Tyson,

wt., 21 lip 2020 o 06:54 tyson andre <tysonandre775@hotmail.com> napisa=C5=
=82(a):

> Hi Micha=C5=82 Marcin Brzuchalski,
>
> At the time of writing, the documentation in
> https://wiki.php.net/rfc/stack-frame-class#stackframe_class is also
> inconsistent with the implementation.
> `public readonly string $file;` is not actually read only in the
> implementation in the GitHub PR. It can be overwritten or deleted with
> `$frame->file =3D 'newfile.php';`
> or `unset($frame->file);`.
> I'd guess this is expressing the desired way that StackFrame instances
> would be used by PHP code,
> but that seems confusing because some properties of other internal classe=
s
> are actually effectively read only due to providing magic getter APIs.
> (Also see my previous comment about ArrayAccess inconsistencies)
> Dropping the readonly from the RFC is one possible way to clarify that.
>

The readonly was dropped in the RFC to meet the implementation similar to
PhpToken  where a developer is free to modify all properties.

Cheers,
Micha=C5=82

--00000000000088e1bf05aaec8762--