Newsgroups: php.internals
Path: news.php.net
Xref: news.php.net php.internals:111083
To: =?iso-8859-2?Q?Micha=B3_Marcin_Brzuchalski?=
	<michal.brzuchalski@gmail.com>, PHP Internals List <internals@lists.php.net>
Thread-Topic: [PHP-DEV] Re: [RFC][DISCUSSION] debug_backtrace alternative as
 an array of StackFrame objects
Thread-Index: AQHWXtFgqJP43t0OTE2TPa02/q7m7KkROYlEgAA5HhQ=
Date: Tue, 21 Jul 2020 04:54:15 +0000
Message-ID:
 <DM6PR07MB6618A906A660A00C1B7416D7F9780@DM6PR07MB6618.namprd07.prod.outlook.com>
References:
 <CABdc3WpEmoKTYEsDk+K1Jb=kh7nu8gJ3TkhY5639ueJaWjN9AQ@mail.gmail.com>,<CABdc3WrNcPdY03d5oyUSW5nwaTkqd_wGscf2kWwxhD2ykPzRYA@mail.gmail.com>,<DM6PR07MB6618D57BE5B6E246EA112CB8F9780@DM6PR07MB6618.namprd07.prod.outlook.com>
In-Reply-To:
 <DM6PR07MB6618D57BE5B6E246EA112CB8F9780@DM6PR07MB6618.namprd07.prod.outlook.com>
Accept-Language: en-CA, en-US
Content-Language: en-CA
x-ms-exchange-messagesentrepresentingtype: 1
x-tmn: [O9G0fcTDfLo+5BvbcmtqnOTZQgEQ16VjQPrbxlHBW4DDob/X0F3V8VxeYwtptMWw]
x-ms-publictraffictype: Email
x-incomingheadercount: 44
x-eopattributedmessage: 0
x-ms-office365-filtering-correlation-id: fe6af1d4-e557-4ae9-209c-08d82d321eac
x-ms-traffictypediagnostic: CO1NAM11HT249:
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info:
 6GnnpsHZCTYvLbkDUsJBK07W5NoMoCqqShzLdD1wHRyVw5UI+T6cDrNnQIqIIw8LqhZeg5HloKHeqxMRQaVLo8yX8QvimizWcRtKPaP6umIM3/1Yiyjqm9jHr2n+QT8BZ/hqfhRtAWAR/5HJYt3tH4geYNFSK26sLnYn/Z7UtskFZYwR7w9qSY881lQK3rzpEUNQaC2Ftn8ad+4XIabf/Phl+wVqAxgtpYOYqI6DXpvRvL9OD2211t1hASq4Bf7o
x-forefront-antispam-report:
 CIP:255.255.255.255;CTRY:;LANG:en;SCL:0;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR07MB6618.namprd07.prod.outlook.com;PTR:;CAT:NONE;SFTY:;SFS:;DIR:OUT;SFP:1901;
x-ms-exchange-antispam-messagedata:
 +qb6D4M1XF0gw2mtnbqfbPi0crglCyMOmCNgO3jeEiXA2A2wO06A0pyaHekTy70oJ/FcnDQmKSIVDRyH/rprpBGPm8xgrD/BxBH+exUFlEuJbeFIQyMI21QUfS9/E8qTujP5tDbhyX139OutaALBcK+C9akvWtbTyaH2mOpXQIeeoji7peeVdGz6smbIMoJg72tFZ6DGs+XjpnpQ5udJGg==
x-ms-exchange-transport-forked: True
Content-Type: text/plain; charset="iso-8859-2"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: hotmail.com
X-MS-Exchange-CrossTenant-AuthAs: Anonymous
X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT015.eop-nam11.prod.protection.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: fe6af1d4-e557-4ae9-209c-08d82d321eac
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jul 2020 04:54:15.7987
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Internet
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1NAM11HT249
Subject: Re: [PHP-DEV] Re: [RFC][DISCUSSION] debug_backtrace alternative as an
 array of StackFrame objects
From: tysonandre775@hotmail.com (tyson andre)

Hi Micha=B3 Marcin Brzuchalski,=0A=
=0A=
At the time of writing, the documentation in https://wiki.php.net/rfc/stack=
-frame-class#stackframe_class is also inconsistent with the implementation.=
=0A=
`public readonly string $file;` is not actually read only in the implementa=
tion in the GitHub PR. It can be overwritten or deleted with `$frame->file =
=3D 'newfile.php';`=0A=
or `unset($frame->file);`.=0A=
I'd guess this is expressing the desired way that StackFrame instances woul=
d be used by PHP code,=0A=
but that seems confusing because some properties of other internal classes =
are actually effectively read only due to providing magic getter APIs.=0A=
(Also see my previous comment about ArrayAccess inconsistencies)=0A=
Dropping the readonly from the RFC is one possible way to clarify that.=0A=
=0A=
```=0A=
final class StackFrame implements ArrayAccess=0A=
{=0A=
    public readonly string $file;=0A=
 =0A=
    public readonly int $line;=0A=
 ```=0A=
=0A=
The first time I've compiled or looked at the implementation and RFC docume=
nt in detail was this evening, out of a curiosity of how it worked=0A=
and to look into the performance impact to expect,=0A=
after seeing the vote announcement this morning.=0A=
=0A=
> Sorry for the late comment - I'd been busy/occupied with various other th=
ings and this RFC fell off my radar=0A=
=0A=
Regards,=0A=
- Tyson=0A=